Tests for plot recipes #37
Conversation
SebastianM-C
left a comment
SebastianM-C
left a comment
There was a problem hiding this comment.
Thanks. I think we could make it runnable on CI be checking ENV[CI]
test/runtests.jl
Outdated
| Lx, y, z = Lx_slice(joinpath(dir, file), λ, 0) | ||
| @test length(Lx) > 0 | ||
| @test length(Lx) == length(y) == length(z) | ||
| dir = "/mnt/storage/epoch/Wang-Arefiev2020mod/12mtt_0.8w0_l0_MDO" |
There was a problem hiding this comment.
We could use the CI env variable to see what path to use. In case we are on CI, we could use the .sdf in the test folder.
|
CI fails because it doesn't have the custom registry added |
Co-authored-by: Sebastian Micluța-Câmpeanu <[email protected]>
| @test length(Lx) > 0 | ||
| @test length(Lx) == length(y) == length(z) | ||
| dir = "/mnt/storage/epoch/Wang-Arefiev2020mod/12mtt_0.8w0_l0_MDO" | ||
| sim = read_simulation(dir) |
There was a problem hiding this comment.
You need to add using SDFResults for this to work
|
CI should work on linux now. On windows there is a problem with adding the registry and on MacOS there is an issue with PyCall |
SebastianM-C
left a comment
SebastianM-C
left a comment
There was a problem hiding this comment.
Should be good to go with the suggestion
|
@DolineanuMircea We should create some simple simulations which contain the data that we need (like photons or particle weights) and add it for the tests. It shouldn't be larger than the current sdf in the repo. |
No description provided.