add tests proving that frozen columns work and undo checking for frozen records

Author: ignacio-chiazzo

lib/annotate/annotate_models.rb

@@ -940,8 +940,6 @@ def get_attributes(column, column_type, klass, options)
       attrs << 'not null' unless column.null
       attrs << 'primary key' if klass.primary_key && (klass.primary_key.is_a?(Array) ? klass.primary_key.collect(&:to_sym).include?(column.name.to_sym) : column.name.to_sym == klass.primary_key.to_sym)
 
-      column_type = column_type.dup if column_type.frozen?
-
       if column_type == 'decimal'
         column_type << "(#{column.precision}, #{column.scale})"
       elsif !%w[spatial geometry geography].include?(column_type)

spec/lib/tasks/annotate_models_spec.rb

@@ -43,20 +43,18 @@
 
     before do
       allow(klass).to receive(:columns).and_return([
-        double('Column', name: 'id', type: 'integer'.freeze, sql_type: 'integer', limit: nil, null: false, default: nil, comment: nil)
+        instance_double('Column', name: 'id', type: 'integer'.freeze, sql_type: 'integer', limit: nil, null: false, default: nil, comment: nil)
       ])
       allow(klass).to receive(:table_exists?).and_return(true)
       allow(klass).to receive(:primary_key).and_return('id')
     end
 
     it 'does not raise an error when modifying column_type' do
-      expect {
-        AnnotateModels.get_schema_info(klass, "Schema Info", {})
-      }.not_to raise_error
+      expect { AnnotateModels.get_schema_info(klass, 'Schema Info', {}) }.not_to raise_error
     end
 
     it 'includes the column information in the schema info' do
-      schema_info = AnnotateModels.get_schema_info(klass, "Schema Info", {})
+      schema_info = AnnotateModels.get_schema_info(klass, 'Schema Info', {})
       expect(schema_info).to include('id :integer')
     end
   end