Skip to content

Commit f0d10d6

Browse files
committed
Reverted refactors.
1 parent 65770b5 commit f0d10d6

File tree

3 files changed

+75
-84
lines changed

3 files changed

+75
-84
lines changed

.rubocop_todo.yml

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config`
3-
# on 2016-01-23 17:15:16 +0100 using RuboCop version 0.36.0.
3+
# on 2016-01-25 09:57:25 +0100 using RuboCop version 0.36.0.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
@@ -105,7 +105,7 @@ Metrics/MethodLength:
105105
# Offense count: 2
106106
# Configuration parameters: CountComments.
107107
Metrics/ModuleLength:
108-
Max: 444
108+
Max: 507
109109

110110
# Offense count: 7
111111
Metrics/PerceivedComplexity:
@@ -207,15 +207,14 @@ Style/ConditionalAssignment:
207207
- 'bin/annotate'
208208
- 'lib/annotate/annotate_models.rb'
209209

210-
# Offense count: 8
210+
# Offense count: 7
211211
Style/Documentation:
212212
Exclude:
213213
- 'spec/**/*'
214214
- 'test/**/*'
215215
- 'lib/annotate.rb'
216216
- 'lib/annotate/active_record_patch.rb'
217217
- 'lib/annotate/annotate_models.rb'
218-
- 'lib/annotate/file_patterns.rb'
219218
- 'lib/annotate/version.rb'
220219
- 'lib/generators/annotate/install_generator.rb'
221220
- 'lib/tasks/migrate.rake'
@@ -267,7 +266,6 @@ Style/ExtraSpacing:
267266
Exclude:
268267
- 'Guardfile'
269268
- 'lib/annotate/annotate_models.rb'
270-
- 'lib/annotate/file_patterns.rb'
271269
- 'lib/tasks/annotate_routes.rake'
272270
- 'spec/integration/rails_2.3_with_bundler/script/console'
273271
- 'spec/integration/rails_3.2.2/script/rails'
@@ -632,7 +630,7 @@ Style/SpaceInsideStringInterpolation:
632630
Style/SpecialGlobalVars:
633631
Enabled: false
634632

635-
# Offense count: 411
633+
# Offense count: 384
636634
# Cop supports --auto-correct.
637635
# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
638636
# SupportedStyles: single_quotes, double_quotes
@@ -661,14 +659,13 @@ Style/Tab:
661659
- 'spec/integration/rails_4.2.0/app/models/sub1/sub2/sub3/event.rb'
662660
- 'spec/integration/rails_4.2.0/app/models/task.rb'
663661

664-
# Offense count: 6
662+
# Offense count: 5
665663
# Cop supports --auto-correct.
666664
# Configuration parameters: EnforcedStyle, SupportedStyles.
667665
# SupportedStyles: final_newline, final_blank_line
668666
Style/TrailingBlankLines:
669667
Exclude:
670668
- 'Guardfile'
671-
- 'lib/annotate/file_patterns.rb'
672669
- 'spec/integration/rails_4.1.1/app/models/task_observer.rb'
673670
- 'spec/integration/rails_4.1.1/config/initializers/cookies_serializer.rb'
674671
- 'spec/integration/rails_4.2.0/app/models/task_observer.rb'
@@ -682,22 +679,20 @@ Style/TrailingCommaInArguments:
682679
Exclude:
683680
- 'spec/annotate/annotate_models_spec.rb'
684681

685-
# Offense count: 12
682+
# Offense count: 8
686683
# Cop supports --auto-correct.
687684
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
688685
# SupportedStyles: comma, consistent_comma, no_comma
689686
Style/TrailingCommaInLiteral:
690687
Exclude:
691-
- 'lib/annotate/file_patterns.rb'
692688
- 'spec/annotate/annotate_models_spec.rb'
693689
- 'spec/integration/rails_4.1.1/lib/tasks/auto_annotate_models.rake'
694690
- 'spec/integration/rails_4.2.0/lib/tasks/auto_annotate_models.rake'
695691

696-
# Offense count: 3
692+
# Offense count: 2
697693
# Cop supports --auto-correct.
698694
Style/TrailingWhitespace:
699695
Exclude:
700-
- 'lib/annotate/annotate_models.rb'
701696
- 'spec/annotate/annotate_models_spec.rb'
702697
- 'spec/integration/rails_2.3_with_bundler/db/schema.rb'
703698

lib/annotate/annotate_models.rb

Lines changed: 68 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
require 'bigdecimal'
2-
require 'annotate/file_patterns'
32

43
module AnnotateModels
54
TRUE_RE = /^(true|t|yes|y|1)$/i
@@ -78,6 +77,73 @@ def root_dir
7877

7978
attr_writer :root_dir
8079

80+
def test_files(root_directory)
81+
[
82+
File.join(root_directory, UNIT_TEST_DIR, "%MODEL_NAME%_test.rb"),
83+
File.join(root_directory, MODEL_TEST_DIR, "%MODEL_NAME%_test.rb"),
84+
File.join(root_directory, SPEC_MODEL_DIR, "%MODEL_NAME%_spec.rb")
85+
]
86+
end
87+
88+
def fixture_files(root_directory)
89+
[
90+
File.join(root_directory, FIXTURE_TEST_DIR, "%TABLE_NAME%.yml"),
91+
File.join(root_directory, FIXTURE_SPEC_DIR, "%TABLE_NAME%.yml"),
92+
File.join(root_directory, FIXTURE_TEST_DIR, "%PLURALIZED_MODEL_NAME%.yml"),
93+
File.join(root_directory, FIXTURE_SPEC_DIR, "%PLURALIZED_MODEL_NAME%.yml")
94+
]
95+
end
96+
97+
def scaffold_files(root_directory)
98+
[
99+
File.join(root_directory, CONTROLLER_TEST_DIR, "%PLURALIZED_MODEL_NAME%_controller_test.rb"),
100+
File.join(root_directory, CONTROLLER_SPEC_DIR, "%PLURALIZED_MODEL_NAME%_controller_spec.rb"),
101+
File.join(root_directory, REQUEST_SPEC_DIR, "%PLURALIZED_MODEL_NAME%_spec.rb"),
102+
File.join(root_directory, ROUTING_SPEC_DIR, "%PLURALIZED_MODEL_NAME%_routing_spec.rb")
103+
]
104+
end
105+
106+
def factory_files(root_directory)
107+
[
108+
File.join(root_directory, EXEMPLARS_TEST_DIR, "%MODEL_NAME%_exemplar.rb"),
109+
File.join(root_directory, EXEMPLARS_SPEC_DIR, "%MODEL_NAME%_exemplar.rb"),
110+
File.join(root_directory, BLUEPRINTS_TEST_DIR, "%MODEL_NAME%_blueprint.rb"),
111+
File.join(root_directory, BLUEPRINTS_SPEC_DIR, "%MODEL_NAME%_blueprint.rb"),
112+
File.join(root_directory, FACTORY_GIRL_TEST_DIR, "%MODEL_NAME%_factory.rb"), # (old style)
113+
File.join(root_directory, FACTORY_GIRL_SPEC_DIR, "%MODEL_NAME%_factory.rb"), # (old style)
114+
File.join(root_directory, FACTORY_GIRL_TEST_DIR, "%TABLE_NAME%.rb"), # (new style)
115+
File.join(root_directory, FACTORY_GIRL_SPEC_DIR, "%TABLE_NAME%.rb"), # (new style)
116+
File.join(root_directory, FABRICATORS_TEST_DIR, "%MODEL_NAME%_fabricator.rb"),
117+
File.join(root_directory, FABRICATORS_SPEC_DIR, "%MODEL_NAME%_fabricator.rb")
118+
]
119+
end
120+
121+
def serialize_files(root_directory)
122+
[
123+
File.join(root_directory, SERIALIZERS_DIR, "%MODEL_NAME%_serializer.rb"),
124+
File.join(root_directory, SERIALIZERS_TEST_DIR, "%MODEL_NAME%_serializer_spec.rb"),
125+
File.join(root_directory, SERIALIZERS_SPEC_DIR, "%MODEL_NAME%_serializer_spec.rb")
126+
]
127+
end
128+
129+
def files_by_pattern(root_directory, pattern_type)
130+
case pattern_type
131+
when 'test' then test_files(root_directory)
132+
when 'fixture' then fixture_files(root_directory)
133+
when 'scaffold' then scaffold_files(root_directory)
134+
when 'factory' then factory_files(root_directory)
135+
when 'serializer' then serialize_files(root_directory)
136+
when 'controller'
137+
[File.join(root_directory, CONTROLLER_DIR, "%PLURALIZED_MODEL_NAME%_controller.rb")]
138+
when 'admin'
139+
[File.join(root_directory, ACTIVEADMIN_DIR, "%MODEL_NAME%.rb")]
140+
when 'helper'
141+
[File.join(root_directory, HELPER_DIR, "%PLURALIZED_MODEL_NAME%_helper.rb")]
142+
else
143+
[]
144+
end
145+
end
146+
81147
def get_patterns(pattern_types=[])
82148
current_patterns = []
83149
root_dir.each do |root_directory|
@@ -233,7 +299,7 @@ def get_index_info(klass, options={})
233299
index_info << sprintf("# %-#{max_size}.#{max_size}s %s %s", index.name, "(#{index.columns.join(",")})", index.unique ? "UNIQUE" : "").rstrip + "\n"
234300
end
235301
end
236-
302+
237303
index_info
238304
end
239305

lib/annotate/file_patterns.rb

Lines changed: 0 additions & 70 deletions
This file was deleted.

0 commit comments

Comments
 (0)