fix: update how a session token is applied

Author: jwilkinson87

src/main/kotlin/com/ctrlhub/core/Api.kt

@@ -2,21 +2,23 @@ package com.ctrlhub.core
 
 import com.ctrlhub.core.http.KtorClientFactory
 import io.ktor.client.*
+import io.ktor.client.plugins.defaultRequest
 
 /**
  * The facade object through which interaction with the API occurs.
  */
 class Api(
     var httpClient: HttpClient = KtorClientFactory.create()
 ) {
-    private var sessionToken: String? = null
-
     fun withHttpClientConfig(config: HttpClientConfig<*>.() -> Unit) {
         httpClient = KtorClientFactory.create(configBlock = config)
     }
 
-    fun applySessionToken(newSessionToken: String) {
-        sessionToken = newSessionToken
-        httpClient = KtorClientFactory.createWithExistingConfig(httpClient, newSessionToken)
+    fun applySessionToken(sessionToken: String) {
+        httpClient = KtorClientFactory.create(httpClient) {
+            defaultRequest {
+                headers.append("X-Session-Token", sessionToken)
+            }
+        }
     }
 }

src/main/kotlin/com/ctrlhub/core/http/KtorClientFactory.kt

@@ -21,28 +21,18 @@ import java.util.concurrent.atomic.AtomicReference
 object KtorClientFactory {
     fun create(
         httpClient: HttpClient = HttpClient(CIO),
-        sessionToken: String? = null,
         configBlock: HttpClientConfig<*>.() -> Unit = {}
     ): HttpClient {
-        return configureHttpClient(httpClient, sessionToken, configBlock)
-    }
-
-    fun createWithExistingConfig(
-        existingClient: HttpClient,
-        sessionToken: String? = null
-    ): HttpClient {
-        return configureHttpClient(existingClient, sessionToken)
+        return configureHttpClient(httpClient, configBlock)
     }
 
     private fun configureHttpClient(
         baseClient: HttpClient,
-        sessionToken: String? = null,
         configBlock: HttpClientConfig<*>.() -> Unit = {}
     ): HttpClient {
         return baseClient.config {
             defaultRequest {
                 url(Config.apiBaseUrl)
-                sessionToken?.let { headers.append("X-Session-Token", it) }
                 headers.appendIfNameAbsent(HttpHeaders.ContentType, "application/json")
             }
             expectSuccess = true