usb: gadget: udc: fix NULL dereference in remove()

Dan Carpenter · gregkh · commit 016da9c65fec · 2023-05-29T15:24:24.000+01:00
The "udc" pointer was never set in the probe() function so it will lead to a NULL dereference in udc_pci_remove() when we do: usb_del_gadget_udc(&udc->gadget); Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/ZG+A/dNpFWAlCChk@kili Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/gadget/udc/amd5536udc_pci.c b/drivers/usb/gadget/udc/amd5536udc_pci.c
@@ -170,6 +170,9 @@ static int udc_pci_probe(
 		retval = -ENODEV;
 		goto err_probe;
 	}
+
+	udc = dev;
+
 	return 0;
 
 err_probe:

Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,9 @@ static int udc_pci_probe(`
`170`	`170`	`retval = -ENODEV;`
`171`	`171`	`goto err_probe;`
`172`	`172`	`}`
	`173`	`+`
	`174`	`+ udc = dev;`
	`175`	`+`
`173`	`176`	`return 0;`
`174`	`177`
`175`	`178`	`err_probe:`