Skip to content

Commit 071f24a

Browse files
sean-jcbonzini
authored andcommitted
KVM: Rename arch hooks related to per-CPU virtualization enabling
Rename the per-CPU hooks used to enable virtualization in hardware to align with the KVM-wide helpers in kvm_main.c, and to better capture that the callbacks are invoked on every online CPU. No functional change intended. Suggested-by: Paolo Bonzini <[email protected]> Signed-off-by: Sean Christopherson <[email protected]> Reviewed-by: Kai Huang <[email protected]> Message-ID: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 70c0194 commit 071f24a

File tree

7 files changed

+16
-16
lines changed

7 files changed

+16
-16
lines changed

arch/arm64/kvm/arm.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2163,7 +2163,7 @@ static void cpu_hyp_uninit(void *discard)
21632163
}
21642164
}
21652165

2166-
int kvm_arch_hardware_enable(void)
2166+
int kvm_arch_enable_virtualization_cpu(void)
21672167
{
21682168
/*
21692169
* Most calls to this function are made with migration
@@ -2183,7 +2183,7 @@ int kvm_arch_hardware_enable(void)
21832183
return 0;
21842184
}
21852185

2186-
void kvm_arch_hardware_disable(void)
2186+
void kvm_arch_disable_virtualization_cpu(void)
21872187
{
21882188
kvm_timer_cpu_down();
21892189
kvm_vgic_cpu_down();
@@ -2379,7 +2379,7 @@ static int __init do_pkvm_init(u32 hyp_va_bits)
23792379

23802380
/*
23812381
* The stub hypercalls are now disabled, so set our local flag to
2382-
* prevent a later re-init attempt in kvm_arch_hardware_enable().
2382+
* prevent a later re-init attempt in kvm_arch_enable_virtualization_cpu().
23832383
*/
23842384
__this_cpu_write(kvm_hyp_initialized, 1);
23852385
preempt_enable();

arch/loongarch/kvm/main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ long kvm_arch_dev_ioctl(struct file *filp,
261261
return -ENOIOCTLCMD;
262262
}
263263

264-
int kvm_arch_hardware_enable(void)
264+
int kvm_arch_enable_virtualization_cpu(void)
265265
{
266266
unsigned long env, gcfg = 0;
267267

@@ -300,7 +300,7 @@ int kvm_arch_hardware_enable(void)
300300
return 0;
301301
}
302302

303-
void kvm_arch_hardware_disable(void)
303+
void kvm_arch_disable_virtualization_cpu(void)
304304
{
305305
write_csr_gcfg(0);
306306
write_csr_gstat(0);

arch/mips/kvm/mips.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,12 @@ int kvm_arch_vcpu_should_kick(struct kvm_vcpu *vcpu)
125125
return 1;
126126
}
127127

128-
int kvm_arch_hardware_enable(void)
128+
int kvm_arch_enable_virtualization_cpu(void)
129129
{
130130
return kvm_mips_callbacks->hardware_enable();
131131
}
132132

133-
void kvm_arch_hardware_disable(void)
133+
void kvm_arch_disable_virtualization_cpu(void)
134134
{
135135
kvm_mips_callbacks->hardware_disable();
136136
}

arch/riscv/kvm/main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ long kvm_arch_dev_ioctl(struct file *filp,
2020
return -EINVAL;
2121
}
2222

23-
int kvm_arch_hardware_enable(void)
23+
int kvm_arch_enable_virtualization_cpu(void)
2424
{
2525
csr_write(CSR_HEDELEG, KVM_HEDELEG_DEFAULT);
2626
csr_write(CSR_HIDELEG, KVM_HIDELEG_DEFAULT);
@@ -35,7 +35,7 @@ int kvm_arch_hardware_enable(void)
3535
return 0;
3636
}
3737

38-
void kvm_arch_hardware_disable(void)
38+
void kvm_arch_disable_virtualization_cpu(void)
3939
{
4040
kvm_riscv_aia_disable();
4141

arch/x86/kvm/x86.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ static void kvm_on_user_return(struct user_return_notifier *urn)
355355

356356
/*
357357
* Disabling irqs at this point since the following code could be
358-
* interrupted and executed through kvm_arch_hardware_disable()
358+
* interrupted and executed through kvm_arch_disable_virtualization_cpu()
359359
*/
360360
local_irq_save(flags);
361361
if (msrs->registered) {
@@ -12512,7 +12512,7 @@ void kvm_vcpu_deliver_sipi_vector(struct kvm_vcpu *vcpu, u8 vector)
1251212512
}
1251312513
EXPORT_SYMBOL_GPL(kvm_vcpu_deliver_sipi_vector);
1251412514

12515-
int kvm_arch_hardware_enable(void)
12515+
int kvm_arch_enable_virtualization_cpu(void)
1251612516
{
1251712517
struct kvm *kvm;
1251812518
struct kvm_vcpu *vcpu;
@@ -12608,7 +12608,7 @@ int kvm_arch_hardware_enable(void)
1260812608
return 0;
1260912609
}
1261012610

12611-
void kvm_arch_hardware_disable(void)
12611+
void kvm_arch_disable_virtualization_cpu(void)
1261212612
{
1261312613
kvm_x86_call(hardware_disable)();
1261412614
drop_user_return_notifiers();

include/linux/kvm_host.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1521,8 +1521,8 @@ static inline void kvm_create_vcpu_debugfs(struct kvm_vcpu *vcpu) {}
15211521
#endif
15221522

15231523
#ifdef CONFIG_KVM_GENERIC_HARDWARE_ENABLING
1524-
int kvm_arch_hardware_enable(void);
1525-
void kvm_arch_hardware_disable(void);
1524+
int kvm_arch_enable_virtualization_cpu(void);
1525+
void kvm_arch_disable_virtualization_cpu(void);
15261526
#endif
15271527
int kvm_arch_vcpu_runnable(struct kvm_vcpu *vcpu);
15281528
bool kvm_arch_vcpu_in_kernel(struct kvm_vcpu *vcpu);

virt/kvm/kvm_main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5583,7 +5583,7 @@ static int kvm_enable_virtualization_cpu(void)
55835583
if (__this_cpu_read(virtualization_enabled))
55845584
return 0;
55855585

5586-
if (kvm_arch_hardware_enable()) {
5586+
if (kvm_arch_enable_virtualization_cpu()) {
55875587
pr_info("kvm: enabling virtualization on CPU%d failed\n",
55885588
raw_smp_processor_id());
55895589
return -EIO;
@@ -5608,7 +5608,7 @@ static void kvm_disable_virtualization_cpu(void *ign)
56085608
if (!__this_cpu_read(virtualization_enabled))
56095609
return;
56105610

5611-
kvm_arch_hardware_disable();
5611+
kvm_arch_disable_virtualization_cpu();
56125612

56135613
__this_cpu_write(virtualization_enabled, false);
56145614
}

0 commit comments

Comments
 (0)