drm/xe: Fix xe_tile_init_noalloc() error propagation

lucasdemarchi · lucasdemarchi · commit 0bcf41171c64 · 2025-02-14T11:42:54.000-08:00
Propagate the error to the caller so initialization properly stops if sysfs creation fails. Reviewed-by: Francois Dugast <francois.dugast@intel.com> Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250213192909.996148-4-lucas.demarchi@intel.com Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
@@ -168,9 +168,7 @@ int xe_tile_init_noalloc(struct xe_tile *tile)
 
 	xe_wa_apply_tile_workarounds(tile);
 
-	err = xe_tile_sysfs_init(tile);
-
-	return 0;
+	return xe_tile_sysfs_init(tile);
 }
 
 int xe_tile_init(struct xe_tile *tile)

Original file line number	Diff line number	Diff line change
`@@ -168,9 +168,7 @@ int xe_tile_init_noalloc(struct xe_tile *tile)`
`168`	`168`
`169`	`169`	`xe_wa_apply_tile_workarounds(tile);`
`170`	`170`
`171`		`- err = xe_tile_sysfs_init(tile);`
`172`		`-`
`173`		`- return 0;`
	`171`	`+ return xe_tile_sysfs_init(tile);`
`174`	`172`	`}`
`175`	`173`
`176`	`174`	`int xe_tile_init(struct xe_tile *tile)`