Skip to content

Commit 0c3f3a8

Browse files
easwarhtdz
authored andcommitted
drm/gma500: Make I2C terminology more inclusive
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Acked-by: Thomas Zimmermann <[email protected]> Signed-off-by: Easwar Hariharan <[email protected]> Signed-off-by: Thomas Zimmermann <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 61671d8 commit 0c3f3a8

File tree

8 files changed

+32
-32
lines changed

8 files changed

+32
-32
lines changed

drivers/gpu/drm/gma500/cdv_intel_lvds.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,7 @@ void cdv_intel_lvds_init(struct drm_device *dev,
565565
dev->dev, "I2C bus registration failed.\n");
566566
goto err_encoder_cleanup;
567567
}
568-
gma_encoder->i2c_bus->slave_addr = 0x2C;
568+
gma_encoder->i2c_bus->target_addr = 0x2C;
569569
dev_priv->lvds_i2c_bus = gma_encoder->i2c_bus;
570570

571571
/*

drivers/gpu/drm/gma500/intel_bios.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
#include "psb_intel_drv.h"
1515
#include "psb_intel_reg.h"
1616

17-
#define SLAVE_ADDR1 0x70
18-
#define SLAVE_ADDR2 0x72
17+
#define TARGET_ADDR1 0x70
18+
#define TARGET_ADDR2 0x72
1919

2020
static void *find_section(struct bdb_header *bdb, int section_id)
2121
{
@@ -357,10 +357,10 @@ parse_sdvo_device_mapping(struct drm_psb_private *dev_priv,
357357
/* skip the device block if device type is invalid */
358358
continue;
359359
}
360-
if (p_child->slave_addr != SLAVE_ADDR1 &&
361-
p_child->slave_addr != SLAVE_ADDR2) {
360+
if (p_child->target_addr != TARGET_ADDR1 &&
361+
p_child->target_addr != TARGET_ADDR2) {
362362
/*
363-
* If the slave address is neither 0x70 nor 0x72,
363+
* If the target address is neither 0x70 nor 0x72,
364364
* it is not a SDVO device. Skip it.
365365
*/
366366
continue;
@@ -371,33 +371,33 @@ parse_sdvo_device_mapping(struct drm_psb_private *dev_priv,
371371
DRM_DEBUG_KMS("Incorrect SDVO port. Skip it\n");
372372
continue;
373373
}
374-
DRM_DEBUG_KMS("the SDVO device with slave addr %2x is found on"
374+
DRM_DEBUG_KMS("the SDVO device with target addr %2x is found on"
375375
" %s port\n",
376-
p_child->slave_addr,
376+
p_child->target_addr,
377377
(p_child->dvo_port == DEVICE_PORT_DVOB) ?
378378
"SDVOB" : "SDVOC");
379379
p_mapping = &(dev_priv->sdvo_mappings[p_child->dvo_port - 1]);
380380
if (!p_mapping->initialized) {
381381
p_mapping->dvo_port = p_child->dvo_port;
382-
p_mapping->slave_addr = p_child->slave_addr;
382+
p_mapping->target_addr = p_child->target_addr;
383383
p_mapping->dvo_wiring = p_child->dvo_wiring;
384384
p_mapping->ddc_pin = p_child->ddc_pin;
385385
p_mapping->i2c_pin = p_child->i2c_pin;
386386
p_mapping->initialized = 1;
387387
DRM_DEBUG_KMS("SDVO device: dvo=%x, addr=%x, wiring=%d, ddc_pin=%d, i2c_pin=%d\n",
388388
p_mapping->dvo_port,
389-
p_mapping->slave_addr,
389+
p_mapping->target_addr,
390390
p_mapping->dvo_wiring,
391391
p_mapping->ddc_pin,
392392
p_mapping->i2c_pin);
393393
} else {
394394
DRM_DEBUG_KMS("Maybe one SDVO port is shared by "
395395
"two SDVO device.\n");
396396
}
397-
if (p_child->slave2_addr) {
397+
if (p_child->target2_addr) {
398398
/* Maybe this is a SDVO device with multiple inputs */
399399
/* And the mapping info is not added */
400-
DRM_DEBUG_KMS("there exists the slave2_addr. Maybe this"
400+
DRM_DEBUG_KMS("there exists the target2_addr. Maybe this"
401401
" is a SDVO device with multiple inputs.\n");
402402
}
403403
count++;

drivers/gpu/drm/gma500/intel_bios.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,13 +186,13 @@ struct child_device_config {
186186
u16 addin_offset;
187187
u8 dvo_port; /* See Device_PORT_* above */
188188
u8 i2c_pin;
189-
u8 slave_addr;
189+
u8 target_addr;
190190
u8 ddc_pin;
191191
u16 edid_ptr;
192192
u8 dvo_cfg; /* See DEVICE_CFG_* above */
193193
u8 dvo2_port;
194194
u8 i2c2_pin;
195-
u8 slave2_addr;
195+
u8 target2_addr;
196196
u8 ddc2_pin;
197197
u8 capabilities;
198198
u8 dvo_wiring;/* See DEVICE_WIRE_* above */

drivers/gpu/drm/gma500/intel_gmbus.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ gmbus_xfer(struct i2c_adapter *adapter,
333333
clear_err:
334334
/* Toggle the Software Clear Interrupt bit. This has the effect
335335
* of resetting the GMBUS controller and so clearing the
336-
* BUS_ERROR raised by the slave's NAK.
336+
* BUS_ERROR raised by the target's NAK.
337337
*/
338338
GMBUS_REG_WRITE(GMBUS1 + reg_offset, GMBUS_SW_CLR_INT);
339339
GMBUS_REG_WRITE(GMBUS1 + reg_offset, 0);

drivers/gpu/drm/gma500/psb_drv.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ struct psb_intel_opregion {
202202
struct sdvo_device_mapping {
203203
u8 initialized;
204204
u8 dvo_port;
205-
u8 slave_addr;
205+
u8 target_addr;
206206
u8 dvo_wiring;
207207
u8 i2c_pin;
208208
u8 i2c_speed;

drivers/gpu/drm/gma500/psb_intel_drv.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ struct psb_intel_mode_device {
8080
struct gma_i2c_chan {
8181
struct i2c_adapter base;
8282
struct i2c_algo_bit_data algo;
83-
u8 slave_addr;
83+
u8 target_addr;
8484

8585
/* for getting at dev. private (mmio etc.) */
8686
struct drm_device *drm_dev;

drivers/gpu/drm/gma500/psb_intel_lvds.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ static int psb_lvds_i2c_set_brightness(struct drm_device *dev,
9797

9898
struct i2c_msg msgs[] = {
9999
{
100-
.addr = lvds_i2c_bus->slave_addr,
100+
.addr = lvds_i2c_bus->target_addr,
101101
.flags = 0,
102102
.len = 2,
103103
.buf = out_buf,
@@ -707,7 +707,7 @@ void psb_intel_lvds_init(struct drm_device *dev,
707707
dev->dev, "I2C bus registration failed.\n");
708708
goto err_encoder_cleanup;
709709
}
710-
lvds_priv->i2c_bus->slave_addr = 0x2C;
710+
lvds_priv->i2c_bus->target_addr = 0x2C;
711711
dev_priv->lvds_i2c_bus = lvds_priv->i2c_bus;
712712

713713
/*

drivers/gpu/drm/gma500/psb_intel_sdvo.c

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ struct psb_intel_sdvo {
7070
struct gma_encoder base;
7171

7272
struct i2c_adapter *i2c;
73-
u8 slave_addr;
73+
u8 target_addr;
7474

7575
struct i2c_adapter ddc;
7676

@@ -259,13 +259,13 @@ static bool psb_intel_sdvo_read_byte(struct psb_intel_sdvo *psb_intel_sdvo, u8 a
259259
{
260260
struct i2c_msg msgs[] = {
261261
{
262-
.addr = psb_intel_sdvo->slave_addr,
262+
.addr = psb_intel_sdvo->target_addr,
263263
.flags = 0,
264264
.len = 1,
265265
.buf = &addr,
266266
},
267267
{
268-
.addr = psb_intel_sdvo->slave_addr,
268+
.addr = psb_intel_sdvo->target_addr,
269269
.flags = I2C_M_RD,
270270
.len = 1,
271271
.buf = ch,
@@ -463,14 +463,14 @@ static bool psb_intel_sdvo_write_cmd(struct psb_intel_sdvo *psb_intel_sdvo, u8 c
463463
psb_intel_sdvo_debug_write(psb_intel_sdvo, cmd, args, args_len);
464464

465465
for (i = 0; i < args_len; i++) {
466-
msgs[i].addr = psb_intel_sdvo->slave_addr;
466+
msgs[i].addr = psb_intel_sdvo->target_addr;
467467
msgs[i].flags = 0;
468468
msgs[i].len = 2;
469469
msgs[i].buf = buf + 2 *i;
470470
buf[2*i + 0] = SDVO_I2C_ARG_0 - i;
471471
buf[2*i + 1] = ((u8*)args)[i];
472472
}
473-
msgs[i].addr = psb_intel_sdvo->slave_addr;
473+
msgs[i].addr = psb_intel_sdvo->target_addr;
474474
msgs[i].flags = 0;
475475
msgs[i].len = 2;
476476
msgs[i].buf = buf + 2*i;
@@ -479,12 +479,12 @@ static bool psb_intel_sdvo_write_cmd(struct psb_intel_sdvo *psb_intel_sdvo, u8 c
479479

480480
/* the following two are to read the response */
481481
status = SDVO_I2C_CMD_STATUS;
482-
msgs[i+1].addr = psb_intel_sdvo->slave_addr;
482+
msgs[i+1].addr = psb_intel_sdvo->target_addr;
483483
msgs[i+1].flags = 0;
484484
msgs[i+1].len = 1;
485485
msgs[i+1].buf = &status;
486486

487-
msgs[i+2].addr = psb_intel_sdvo->slave_addr;
487+
msgs[i+2].addr = psb_intel_sdvo->target_addr;
488488
msgs[i+2].flags = I2C_M_RD;
489489
msgs[i+2].len = 1;
490490
msgs[i+2].buf = &status;
@@ -1899,7 +1899,7 @@ psb_intel_sdvo_is_hdmi_connector(struct psb_intel_sdvo *psb_intel_sdvo, int devi
18991899
}
19001900

19011901
static u8
1902-
psb_intel_sdvo_get_slave_addr(struct drm_device *dev, int sdvo_reg)
1902+
psb_intel_sdvo_get_target_addr(struct drm_device *dev, int sdvo_reg)
19031903
{
19041904
struct drm_psb_private *dev_priv = to_drm_psb_private(dev);
19051905
struct sdvo_device_mapping *my_mapping, *other_mapping;
@@ -1913,14 +1913,14 @@ psb_intel_sdvo_get_slave_addr(struct drm_device *dev, int sdvo_reg)
19131913
}
19141914

19151915
/* If the BIOS described our SDVO device, take advantage of it. */
1916-
if (my_mapping->slave_addr)
1917-
return my_mapping->slave_addr;
1916+
if (my_mapping->target_addr)
1917+
return my_mapping->target_addr;
19181918

19191919
/* If the BIOS only described a different SDVO device, use the
19201920
* address that it isn't using.
19211921
*/
1922-
if (other_mapping->slave_addr) {
1923-
if (other_mapping->slave_addr == 0x70)
1922+
if (other_mapping->target_addr) {
1923+
if (other_mapping->target_addr == 0x70)
19241924
return 0x72;
19251925
else
19261926
return 0x70;
@@ -2446,7 +2446,7 @@ bool psb_intel_sdvo_init(struct drm_device *dev, int sdvo_reg)
24462446
return false;
24472447

24482448
psb_intel_sdvo->sdvo_reg = sdvo_reg;
2449-
psb_intel_sdvo->slave_addr = psb_intel_sdvo_get_slave_addr(dev, sdvo_reg) >> 1;
2449+
psb_intel_sdvo->target_addr = psb_intel_sdvo_get_target_addr(dev, sdvo_reg) >> 1;
24502450
psb_intel_sdvo_select_i2c_bus(dev_priv, psb_intel_sdvo, sdvo_reg);
24512451
if (!psb_intel_sdvo_init_ddc_proxy(psb_intel_sdvo, dev)) {
24522452
kfree(psb_intel_sdvo);

0 commit comments

Comments
 (0)