Skip to content

Commit 0d442ce

Browse files
committed
erofs: mark experimental fscache backend deprecated
Although fscache is still described as "General Filesystem Caching" for network filesystems and other things such as ISO9660 filesystems, it has actually become a part of netfslib recently, which was unexpected at the time when "EROFS over fscache" proposed (2021) since EROFS is entirely a disk filesystem and the dependency is redundant. Mark it deprecated and it will be removed after "fanotify pre-content hooks" lands, which will provide the same functionality for EROFS. Reviewed-by: Sandeep Dhavale <[email protected]> Reviewed-by: Chao Yu <[email protected]> Signed-off-by: Gao Xiang <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 2832137 commit 0d442ce

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

fs/erofs/Kconfig

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ config EROFS_FS_ZIP_ZSTD
145145
If unsure, say N.
146146

147147
config EROFS_FS_ONDEMAND
148-
bool "EROFS fscache-based on-demand read support"
148+
bool "EROFS fscache-based on-demand read support (deprecated)"
149149
depends on EROFS_FS
150150
select NETFS_SUPPORT
151151
select FSCACHE
@@ -155,6 +155,9 @@ config EROFS_FS_ONDEMAND
155155
This permits EROFS to use fscache-backed data blobs with on-demand
156156
read support.
157157

158+
It is now deprecated and scheduled to be removed from the kernel
159+
after fanotify pre-content hooks are landed.
160+
158161
If unsure, say N.
159162

160163
config EROFS_FS_PCPU_KTHREAD

fs/erofs/super.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ static int erofs_read_superblock(struct super_block *sb)
353353
ret = erofs_scan_devices(sb, dsb);
354354

355355
if (erofs_is_fscache_mode(sb))
356-
erofs_info(sb, "EXPERIMENTAL fscache-based on-demand read feature in use. Use at your own risk!");
356+
erofs_info(sb, "[deprecated] fscache-based on-demand read feature in use. Use at your own risk!");
357357
out:
358358
erofs_put_metabuf(&buf);
359359
return ret;

0 commit comments

Comments
 (0)