ALSA: PCM: Allow resume only for suspended streams

tiwai · tiwai · commit 1225675ca74c · 2024-06-25T11:53:35.000+02:00
snd_pcm_resume() should bail out if the stream isn't in a suspended state. Otherwise it'd allow doubly resume. Link: https://patch.msgid.link/20240624125443.27808-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
@@ -1775,6 +1775,8 @@ static int snd_pcm_pre_resume(struct snd_pcm_substream *substream,
 			      snd_pcm_state_t state)
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
+	if (runtime->state != SNDRV_PCM_STATE_SUSPENDED)
+		return -EBADFD;
 	if (!(runtime->info & SNDRV_PCM_INFO_RESUME))
 		return -ENOSYS;
 	runtime->trigger_master = substream;

Original file line number	Diff line number	Diff line change
`@@ -1775,6 +1775,8 @@ static int snd_pcm_pre_resume(struct snd_pcm_substream *substream,`
`1775`	`1775`	`snd_pcm_state_t state)`
`1776`	`1776`	`{`
`1777`	`1777`	`struct snd_pcm_runtime *runtime = substream->runtime;`
	`1778`	`+ if (runtime->state != SNDRV_PCM_STATE_SUSPENDED)`
	`1779`	`+ return -EBADFD;`
`1778`	`1780`	`if (!(runtime->info & SNDRV_PCM_INFO_RESUME))`
`1779`	`1781`	`return -ENOSYS;`
`1780`	`1782`	`runtime->trigger_master = substream;`