Skip to content

Commit 1ab1a19

Browse files
committed
Merge tag 'pci-v6.9-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci
Pull pci fixes from Bjorn Helgaas: - Update kernel-parameters doc to describe "pcie_aspm=off" more accurately (Bjorn Helgaas) - Restore the parent's (not the child's) ASPM state to the parent during resume, which fixes a reboot during resume (Kai-Heng Feng) * tag 'pci-v6.9-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci: PCI/ASPM: Restore parent state to parent, child state to child PCI/ASPM: Clarify that pcie_aspm=off means leave ASPM untouched
2 parents dccb07f + f3d049b commit 1ab1a19

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

Documentation/admin-guide/kernel-parameters.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4594,9 +4594,10 @@
45944594
norid [S390] ignore the RID field and force use of
45954595
one PCI domain per PCI function
45964596

4597-
pcie_aspm= [PCIE] Forcibly enable or disable PCIe Active State Power
4597+
pcie_aspm= [PCIE] Forcibly enable or ignore PCIe Active State Power
45984598
Management.
4599-
off Disable ASPM.
4599+
off Don't touch ASPM configuration at all. Leave any
4600+
configuration done by firmware unchanged.
46004601
force Enable ASPM even on devices that claim not to support it.
46014602
WARNING: Forcing ASPM on may cause system lockups.
46024603

drivers/pci/pcie/aspm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,8 @@ void pci_restore_aspm_l1ss_state(struct pci_dev *pdev)
177177
/* Restore L0s/L1 if they were enabled */
178178
if (FIELD_GET(PCI_EXP_LNKCTL_ASPMC, clnkctl) ||
179179
FIELD_GET(PCI_EXP_LNKCTL_ASPMC, plnkctl)) {
180-
pcie_capability_write_word(parent, PCI_EXP_LNKCTL, clnkctl);
181-
pcie_capability_write_word(pdev, PCI_EXP_LNKCTL, plnkctl);
180+
pcie_capability_write_word(parent, PCI_EXP_LNKCTL, plnkctl);
181+
pcie_capability_write_word(pdev, PCI_EXP_LNKCTL, clnkctl);
182182
}
183183
}
184184

0 commit comments

Comments
 (0)