Skip to content

Commit 2ca3e84

Browse files
krzkandersson
authored andcommitted
arm64: dts: qcom: apq8096-db820c: fix missing clock populate
Commit 704e266 ("arm64: dts: qcom: apq8096-db820c: drop simple-bus from clocks") removed "simple-bus" compatible from "clocks" node, but one of the clocks - divclk1 - is a gpio-gate-clock, which does not have CLK_OF_DECLARE. This means it will not be instantiated if placed in some subnode. Move the clocks to the root node, so regular devices will be populated. Reported-by: Dmitry Baryshkov <[email protected]> Closes: https://lore.kernel.org/all/CAA8EJprF==p87oN+RiwAiNeURF1JcHGfL2Ez5zxqYPRRbN-hhg@mail.gmail.com/ Cc: [email protected] Fixes: 704e266 ("arm64: dts: qcom: apq8096-db820c: drop simple-bus from clocks") Signed-off-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Tested-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent f822899 commit 2ca3e84

File tree

1 file changed

+15
-17
lines changed

1 file changed

+15
-17
lines changed

arch/arm64/boot/dts/qcom/apq8096-db820c.dts

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -62,25 +62,23 @@
6262
stdout-path = "serial0:115200n8";
6363
};
6464

65-
clocks {
66-
divclk4: divclk4 {
67-
compatible = "fixed-clock";
68-
#clock-cells = <0>;
69-
clock-frequency = <32768>;
70-
clock-output-names = "divclk4";
65+
div1_mclk: divclk1 {
66+
compatible = "gpio-gate-clock";
67+
pinctrl-0 = <&audio_mclk>;
68+
pinctrl-names = "default";
69+
clocks = <&rpmcc RPM_SMD_DIV_CLK1>;
70+
#clock-cells = <0>;
71+
enable-gpios = <&pm8994_gpios 15 0>;
72+
};
7173

72-
pinctrl-names = "default";
73-
pinctrl-0 = <&divclk4_pin_a>;
74-
};
74+
divclk4: divclk4 {
75+
compatible = "fixed-clock";
76+
#clock-cells = <0>;
77+
clock-frequency = <32768>;
78+
clock-output-names = "divclk4";
7579

76-
div1_mclk: divclk1 {
77-
compatible = "gpio-gate-clock";
78-
pinctrl-0 = <&audio_mclk>;
79-
pinctrl-names = "default";
80-
clocks = <&rpmcc RPM_SMD_DIV_CLK1>;
81-
#clock-cells = <0>;
82-
enable-gpios = <&pm8994_gpios 15 0>;
83-
};
80+
pinctrl-names = "default";
81+
pinctrl-0 = <&divclk4_pin_a>;
8482
};
8583

8684
gpio-keys {

0 commit comments

Comments
 (0)