Skip to content

Commit 310fa3e

Browse files
committed
ALSA: seq: ump: Fix swapped song position pointer data
At converting between the legacy event and UMP, the parameters for MIDI Song Position Pointer are incorrectly stored. It should have been LSB -> MSB order while it stored in MSB -> LSB order. This patch corrects the ordering. Fixes: e9e0281 ("ALSA: seq: Automatic conversion of UMP events") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent e1e287e commit 310fa3e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

sound/core/seq/seq_ump_convert.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ static void ump_system_to_one_param_ev(const union snd_ump_midi1_msg *val,
157157
static void ump_system_to_songpos_ev(const union snd_ump_midi1_msg *val,
158158
struct snd_seq_event *ev)
159159
{
160-
ev->data.control.value = (val->system.parm1 << 7) | val->system.parm2;
160+
ev->data.control.value = (val->system.parm2 << 7) | val->system.parm1;
161161
}
162162

163163
/* Encoders for 0xf0 - 0xff */
@@ -754,8 +754,8 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event,
754754
{
755755
data->system.type = UMP_MSG_TYPE_SYSTEM; // override
756756
data->system.status = status;
757-
data->system.parm1 = (event->data.control.value >> 7) & 0x7f;
758-
data->system.parm2 = event->data.control.value & 0x7f;
757+
data->system.parm1 = event->data.control.value & 0x7f;
758+
data->system.parm2 = (event->data.control.value >> 7) & 0x7f;
759759
return 1;
760760
}
761761

0 commit comments

Comments
 (0)