Skip to content

Commit 34d0472

Browse files
committed
drm/i915: Remove DSC register dump
The Display Engine's DSC register values are deducted from the DSC configuration stored in intel_crtc_state::dsc. The latter one is dumped in a human-readable format, so dumping the register values is redundant, remove it. Acked-by: Jani Nikula <[email protected]> Signed-off-by: Imre Deak <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 1de99ff commit 34d0472

File tree

1 file changed

+2
-22
lines changed

1 file changed

+2
-22
lines changed

drivers/gpu/drm/i915/display/intel_vdsc.c

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -457,70 +457,59 @@ static void intel_dsc_pps_configure(const struct intel_crtc_state *crtc_state)
457457
pps_val |= DSC_PPS0_422_ENABLE;
458458
if (vdsc_cfg->vbr_enable)
459459
pps_val |= DSC_PPS0_VBR_ENABLE;
460-
drm_dbg_kms(&dev_priv->drm, "PPS0 = 0x%08x\n", pps_val);
461460
intel_dsc_pps_write(crtc_state, 0, pps_val);
462461

463462
/* PPS 1 */
464463
pps_val = DSC_PPS1_BPP(vdsc_cfg->bits_per_pixel);
465-
drm_dbg_kms(&dev_priv->drm, "PPS1 = 0x%08x\n", pps_val);
466464
intel_dsc_pps_write(crtc_state, 1, pps_val);
467465

468466
/* PPS 2 */
469467
pps_val = DSC_PPS2_PIC_HEIGHT(vdsc_cfg->pic_height) |
470468
DSC_PPS2_PIC_WIDTH(vdsc_cfg->pic_width / num_vdsc_instances);
471-
drm_dbg_kms(&dev_priv->drm, "PPS2 = 0x%08x\n", pps_val);
472469
intel_dsc_pps_write(crtc_state, 2, pps_val);
473470

474471
/* PPS 3 */
475472
pps_val = DSC_PPS3_SLICE_HEIGHT(vdsc_cfg->slice_height) |
476473
DSC_PPS3_SLICE_WIDTH(vdsc_cfg->slice_width);
477-
drm_dbg_kms(&dev_priv->drm, "PPS3 = 0x%08x\n", pps_val);
478474
intel_dsc_pps_write(crtc_state, 3, pps_val);
479475

480476
/* PPS 4 */
481477
pps_val = DSC_PPS4_INITIAL_XMIT_DELAY(vdsc_cfg->initial_xmit_delay) |
482478
DSC_PPS4_INITIAL_DEC_DELAY(vdsc_cfg->initial_dec_delay);
483-
drm_dbg_kms(&dev_priv->drm, "PPS4 = 0x%08x\n", pps_val);
484479
intel_dsc_pps_write(crtc_state, 4, pps_val);
485480

486481
/* PPS 5 */
487482
pps_val = DSC_PPS5_SCALE_INC_INT(vdsc_cfg->scale_increment_interval) |
488483
DSC_PPS5_SCALE_DEC_INT(vdsc_cfg->scale_decrement_interval);
489-
drm_dbg_kms(&dev_priv->drm, "PPS5 = 0x%08x\n", pps_val);
490484
intel_dsc_pps_write(crtc_state, 5, pps_val);
491485

492486
/* PPS 6 */
493487
pps_val = DSC_PPS6_INITIAL_SCALE_VALUE(vdsc_cfg->initial_scale_value) |
494488
DSC_PPS6_FIRST_LINE_BPG_OFFSET(vdsc_cfg->first_line_bpg_offset) |
495489
DSC_PPS6_FLATNESS_MIN_QP(vdsc_cfg->flatness_min_qp) |
496490
DSC_PPS6_FLATNESS_MAX_QP(vdsc_cfg->flatness_max_qp);
497-
drm_dbg_kms(&dev_priv->drm, "PPS6 = 0x%08x\n", pps_val);
498491
intel_dsc_pps_write(crtc_state, 6, pps_val);
499492

500493
/* PPS 7 */
501494
pps_val = DSC_PPS7_SLICE_BPG_OFFSET(vdsc_cfg->slice_bpg_offset) |
502495
DSC_PPS7_NFL_BPG_OFFSET(vdsc_cfg->nfl_bpg_offset);
503-
drm_dbg_kms(&dev_priv->drm, "PPS7 = 0x%08x\n", pps_val);
504496
intel_dsc_pps_write(crtc_state, 7, pps_val);
505497

506498
/* PPS 8 */
507499
pps_val = DSC_PPS8_FINAL_OFFSET(vdsc_cfg->final_offset) |
508500
DSC_PPS8_INITIAL_OFFSET(vdsc_cfg->initial_offset);
509-
drm_dbg_kms(&dev_priv->drm, "PPS8 = 0x%08x\n", pps_val);
510501
intel_dsc_pps_write(crtc_state, 8, pps_val);
511502

512503
/* PPS 9 */
513504
pps_val = DSC_PPS9_RC_MODEL_SIZE(vdsc_cfg->rc_model_size) |
514505
DSC_PPS9_RC_EDGE_FACTOR(DSC_RC_EDGE_FACTOR_CONST);
515-
drm_dbg_kms(&dev_priv->drm, "PPS9 = 0x%08x\n", pps_val);
516506
intel_dsc_pps_write(crtc_state, 9, pps_val);
517507

518508
/* PPS 10 */
519509
pps_val = DSC_PPS10_RC_QUANT_INC_LIMIT0(vdsc_cfg->rc_quant_incr_limit0) |
520510
DSC_PPS10_RC_QUANT_INC_LIMIT1(vdsc_cfg->rc_quant_incr_limit1) |
521511
DSC_PPS10_RC_TARGET_OFF_HIGH(DSC_RC_TGT_OFFSET_HI_CONST) |
522512
DSC_PPS10_RC_TARGET_OFF_LOW(DSC_RC_TGT_OFFSET_LO_CONST);
523-
drm_dbg_kms(&dev_priv->drm, "PPS10 = 0x%08x\n", pps_val);
524513
intel_dsc_pps_write(crtc_state, 10, pps_val);
525514

526515
/* PPS 16 */
@@ -529,31 +518,25 @@ static void intel_dsc_pps_configure(const struct intel_crtc_state *crtc_state)
529518
vdsc_cfg->slice_width) |
530519
DSC_PPS16_SLICE_ROW_PER_FRAME(vdsc_cfg->pic_height /
531520
vdsc_cfg->slice_height);
532-
drm_dbg_kms(&dev_priv->drm, "PPS16 = 0x%08x\n", pps_val);
533521
intel_dsc_pps_write(crtc_state, 16, pps_val);
534522

535523
if (DISPLAY_VER(dev_priv) >= 14) {
536524
/* PPS 17 */
537525
pps_val = DSC_PPS17_SL_BPG_OFFSET(vdsc_cfg->second_line_bpg_offset);
538-
drm_dbg_kms(&dev_priv->drm, "PPS17 = 0x%08x\n", pps_val);
539526
intel_dsc_pps_write(crtc_state, 17, pps_val);
540527

541528
/* PPS 18 */
542529
pps_val = DSC_PPS18_NSL_BPG_OFFSET(vdsc_cfg->nsl_bpg_offset) |
543530
DSC_PPS18_SL_OFFSET_ADJ(vdsc_cfg->second_line_offset_adj);
544-
drm_dbg_kms(&dev_priv->drm, "PPS18 = 0x%08x\n", pps_val);
545531
intel_dsc_pps_write(crtc_state, 18, pps_val);
546532
}
547533

548534
/* Populate the RC_BUF_THRESH registers */
549535
memset(rc_buf_thresh_dword, 0, sizeof(rc_buf_thresh_dword));
550-
for (i = 0; i < DSC_NUM_BUF_RANGES - 1; i++) {
536+
for (i = 0; i < DSC_NUM_BUF_RANGES - 1; i++)
551537
rc_buf_thresh_dword[i / 4] |=
552538
(u32)(vdsc_cfg->rc_buf_thresh[i] <<
553539
BITS_PER_BYTE * (i % 4));
554-
drm_dbg_kms(&dev_priv->drm, "RC_BUF_THRESH_%d = 0x%08x\n", i,
555-
rc_buf_thresh_dword[i / 4]);
556-
}
557540
if (!is_pipe_dsc(crtc, cpu_transcoder)) {
558541
intel_de_write(dev_priv, DSCA_RC_BUF_THRESH_0,
559542
rc_buf_thresh_dword[0]);
@@ -600,17 +583,14 @@ static void intel_dsc_pps_configure(const struct intel_crtc_state *crtc_state)
600583

601584
/* Populate the RC_RANGE_PARAMETERS registers */
602585
memset(rc_range_params_dword, 0, sizeof(rc_range_params_dword));
603-
for (i = 0; i < DSC_NUM_BUF_RANGES; i++) {
586+
for (i = 0; i < DSC_NUM_BUF_RANGES; i++)
604587
rc_range_params_dword[i / 2] |=
605588
(u32)(((vdsc_cfg->rc_range_params[i].range_bpg_offset <<
606589
RC_BPG_OFFSET_SHIFT) |
607590
(vdsc_cfg->rc_range_params[i].range_max_qp <<
608591
RC_MAX_QP_SHIFT) |
609592
(vdsc_cfg->rc_range_params[i].range_min_qp <<
610593
RC_MIN_QP_SHIFT)) << 16 * (i % 2));
611-
drm_dbg_kms(&dev_priv->drm, "RC_RANGE_PARAM_%d = 0x%08x\n", i,
612-
rc_range_params_dword[i / 2]);
613-
}
614594
if (!is_pipe_dsc(crtc, cpu_transcoder)) {
615595
intel_de_write(dev_priv, DSCA_RC_RANGE_PARAMETERS_0,
616596
rc_range_params_dword[0]);

0 commit comments

Comments
 (0)