Skip to content

Commit 35ca486

Browse files
brentlubroonie
authored andcommitted
ASoC: Intel: bxt_da7219_max98357a: remove cml support
Remove cml platform support and use sof_da7219 machine driver instead for existing cml boards with MAX98357A speaker amplifier. Reviewed-by: Bard Liao <[email protected]> Signed-off-by: Brent Lu <[email protected]> Signed-off-by: Pierre-Louis Bossart <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent e895d16 commit 35ca486

File tree

3 files changed

+4
-32
lines changed

3 files changed

+4
-32
lines changed

sound/soc/intel/boards/Kconfig

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -584,13 +584,11 @@ if (SND_SOC_SOF_COMETLAKE && SND_SOC_SOF_HDA_LINK)
584584

585585
config SND_SOC_INTEL_CML_LP_DA7219_MAX98357A_MACH
586586
tristate "CML_LP with DA7219 and MAX98357A in I2S Mode"
587-
depends on I2C && ACPI
588-
depends on MFD_INTEL_LPSS || COMPILE_TEST
589-
select SND_SOC_INTEL_BXT_DA7219_MAX98357A_COMMON
590587
imply SND_SOC_INTEL_SOF_DA7219_MACH
591588
help
592589
This adds support for ASoC machine driver for Cometlake platforms
593-
with DA7219 + MAX98357A I2S audio codec.
590+
with DA7219 + MAX98357A I2S audio codec. This option is deprecated
591+
and please use SND_SOC_INTEL_SOF_DA7219_MACH instead.
594592
Say Y or m if you have such a device. This is a recommended option.
595593
If unsure select "N".
596594

sound/soc/intel/boards/bxt_da7219_max98357a.c

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,7 @@ static int broxton_da7219_codec_init(struct snd_soc_pcm_runtime *rtd)
201201
int clk_freq;
202202

203203
/* Configure sysclk for codec */
204-
if (soc_intel_is_cml())
205-
clk_freq = 24000000;
206-
else
207-
clk_freq = 19200000;
204+
clk_freq = 19200000;
208205

209206
ret = snd_soc_dai_set_sysclk(codec_dai, DA7219_CLKSRC_MCLK, clk_freq,
210207
SND_SOC_CLOCK_IN);
@@ -721,28 +718,6 @@ static int broxton_audio_probe(struct platform_device *pdev)
721718
broxton_dais[i].cpus->dai_name = "SSP2 Pin";
722719
}
723720
}
724-
} else if (soc_intel_is_cml()) {
725-
unsigned int i;
726-
727-
broxton_audio_card.name = "cmlda7219max";
728-
729-
for (i = 0; i < ARRAY_SIZE(broxton_dais); i++) {
730-
if (!broxton_dais[i].codecs->dai_name)
731-
continue;
732-
733-
/* MAXIM_CODEC is connected to SSP1. */
734-
if (!strcmp(broxton_dais[i].codecs->dai_name,
735-
BXT_MAXIM_CODEC_DAI)) {
736-
broxton_dais[i].name = "SSP1-Codec";
737-
broxton_dais[i].cpus->dai_name = "SSP1 Pin";
738-
}
739-
/* DIALOG_CODEC is connected to SSP0 */
740-
else if (!strcmp(broxton_dais[i].codecs->dai_name,
741-
BXT_DIALOG_CODEC_DAI)) {
742-
broxton_dais[i].name = "SSP0-Codec";
743-
broxton_dais[i].cpus->dai_name = "SSP0 Pin";
744-
}
745-
}
746721
}
747722

748723
/* override platform name, if required */
@@ -762,7 +737,6 @@ static int broxton_audio_probe(struct platform_device *pdev)
762737
static const struct platform_device_id bxt_board_ids[] = {
763738
{ .name = "bxt_da7219_mx98357a" },
764739
{ .name = "glk_da7219_mx98357a" },
765-
{ .name = "cml_da7219_mx98357a" },
766740
{ }
767741
};
768742
MODULE_DEVICE_TABLE(platform, bxt_board_ids);

sound/soc/intel/common/soc-acpi-intel-cml-match.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_cml_machines[] = {
6868
},
6969
{
7070
.id = "DLGS7219",
71-
.drv_name = "cml_da7219_mx98357a",
71+
.drv_name = "cml_da7219_def",
7272
.machine_quirk = snd_soc_acpi_codec_list,
7373
.quirk_data = &max98357a_spk_codecs,
7474
.sof_tplg_filename = "sof-cml-da7219-max98357a.tplg",

0 commit comments

Comments
 (0)