OPP: ti: Fix ti_opp_supply_probe wrong return values

pfiser · vireshk · commit 3a1ac6b8f603 · 2024-06-11T10:58:48.000+05:30
Function ti_opp_supply_probe() since commit 6baee03 ("OPP: ti: Migrate to dev_pm_opp_set_config_regulators()") returns wrong values when all goes well and hence driver probing eventually fails. Fixes: 6baee03 ("OPP: ti: Migrate to dev_pm_opp_set_config_regulators()") Signed-off-by: Primoz Fiser <primoz.fiser@norik.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
@@ -393,10 +393,12 @@ static int ti_opp_supply_probe(struct platform_device *pdev)
 	}
 
 	ret = dev_pm_opp_set_config_regulators(cpu_dev, ti_opp_config_regulators);
-	if (ret < 0)
+	if (ret < 0) {
 		_free_optimized_voltages(dev, &opp_data);
+		return ret;
+	}
 
-	return ret;
+	return 0;
 }
 
 static struct platform_driver ti_opp_supply_driver = {

Original file line number	Diff line number	Diff line change
`@@ -393,10 +393,12 @@ static int ti_opp_supply_probe(struct platform_device *pdev)`
`393`	`393`	`}`
`394`	`394`
`395`	`395`	`ret = dev_pm_opp_set_config_regulators(cpu_dev, ti_opp_config_regulators);`
`396`		`- if (ret < 0)`
	`396`	`+ if (ret < 0) {`
`397`	`397`	`_free_optimized_voltages(dev, &opp_data);`
	`398`	`+ return ret;`
	`399`	`+ }`
`398`	`400`
`399`		`- return ret;`
	`401`	`+ return 0;`
`400`	`402`	`}`
`401`	`403`
`402`	`404`	`static struct platform_driver ti_opp_supply_driver = {`