ALSA: hda: tas2781-i2c: Remove unnecessary NULL check before release_firmware()

Chen Ni · tiwai · commit 3a949fc08103 · 2025-03-25T11:54:44.000+01:00
release_firmware() checks for NULL pointers internally. Remove unneeded NULL check for fmw here. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Link: https://patch.msgid.link/20250325084939.801117-1-nichen@iscas.ac.cn Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
@@ -753,8 +753,7 @@ static void tasdev_fw_ready(const struct firmware *fmw, void *context)
 
 out:
 	mutex_unlock(&tas_hda->priv->codec_lock);
-	if (fmw)
-		release_firmware(fmw);
+	release_firmware(fmw);
 	pm_runtime_mark_last_busy(tas_hda->dev);
 	pm_runtime_put_autosuspend(tas_hda->dev);
 }

Original file line number	Diff line number	Diff line change
`@@ -753,8 +753,7 @@ static void tasdev_fw_ready(const struct firmware fmw, void context)`
`753`	`753`
`754`	`754`	`out:`
`755`	`755`	`mutex_unlock(&tas_hda->priv->codec_lock);`
`756`		`- if (fmw)`
`757`		`- release_firmware(fmw);`
	`756`	`+ release_firmware(fmw);`
`758`	`757`	`pm_runtime_mark_last_busy(tas_hda->dev);`
`759`	`758`	`pm_runtime_put_autosuspend(tas_hda->dev);`
`760`	`759`	`}`