Skip to content

Commit 3c97fe4

Browse files
Dan Carpenterkuba-moo
authored andcommitted
net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code
This error handling has a typo. It should i++ instead of i--. In the original code the error handling will loop until it crashes. Fixes: da70d18 ("net: ethernet: ti: am65-cpsw: Introduce multi queue Rx") Signed-off-by: Dan Carpenter <[email protected]> Reviewed-by: Alexander Sverdlin <[email protected]> Reviewed-by: Roger Quadros <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent c283782 commit 3c97fe4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/ti/am65-cpsw-nuss.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -763,7 +763,7 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common)
763763
k3_udma_glue_disable_rx_chn(rx_chn->rx_chn);
764764

765765
fail_rx:
766-
for (i = 0; i < common->rx_ch_num_flows; i--)
766+
for (i = 0; i < common->rx_ch_num_flows; i++)
767767
k3_udma_glue_reset_rx_chn(rx_chn->rx_chn, i, &rx_chn->flows[i],
768768
am65_cpsw_nuss_rx_cleanup, 0);
769769

0 commit comments

Comments
 (0)