Skip to content

Commit 48f6430

Browse files
MaskRaywilldeacon
authored andcommitted
arm64/vdso: Remove --hash-style=sysv
glibc added support for .gnu.hash in 2006 and .hash has been obsoleted for more than one decade in many Linux distributions. Using --hash-style=sysv might imply unaddressed issues and confuse readers. Just drop the option and rely on the linker default, which is likely "both", or "gnu" when the distribution really wants to eliminate sysv hash overhead. Similar to commit 6b7e265 ("x86/vdso: Emit a GNU hash"). Signed-off-by: Fangrui Song <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]>
1 parent 0c35e3b commit 48f6430

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

arch/arm64/kernel/vdso/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ btildflags-$(CONFIG_ARM64_BTI_KERNEL) += -z force-bti
2121
# potential future proofing if we end up with internal calls to the exported
2222
# routines, as x86 does (see 6f121e548f83 ("x86, vdso: Reimplement vdso.so
2323
# preparation in build-time C")).
24-
ldflags-y := -shared -soname=linux-vdso.so.1 --hash-style=sysv \
24+
ldflags-y := -shared -soname=linux-vdso.so.1 \
2525
-Bsymbolic --build-id=sha1 -n $(btildflags-y)
2626

2727
ifdef CONFIG_LD_ORPHAN_WARN

arch/arm64/kernel/vdso32/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ VDSO_AFLAGS += -D__ASSEMBLY__
9898
# From arm vDSO Makefile
9999
VDSO_LDFLAGS += -Bsymbolic --no-undefined -soname=linux-vdso.so.1
100100
VDSO_LDFLAGS += -z max-page-size=4096 -z common-page-size=4096
101-
VDSO_LDFLAGS += -shared --hash-style=sysv --build-id=sha1
101+
VDSO_LDFLAGS += -shared --build-id=sha1
102102
VDSO_LDFLAGS += --orphan-handling=$(CONFIG_LD_ORPHAN_WARN_LEVEL)
103103

104104

0 commit comments

Comments
 (0)