Skip to content

Commit 4f23382

Browse files
rohangt07kuba-moo
authored andcommitted
net: stmmac: xgmac: Do not enable RX FIFO Overflow interrupts
Enabling RX FIFO Overflow interrupts is counterproductive and causes an interrupt storm when RX FIFO overflows. Disabling this interrupt has no side effect and eliminates interrupt storms when the RX FIFO overflows. Commit 8a7cb24 ("net: stmmac: Do not enable RX FIFO overflow interrupts") disables RX FIFO overflow interrupts for DWMAC4 IP and removes the corresponding handling of this interrupt. This patch is doing the same thing for XGMAC IP. Fixes: 2142754 ("net: stmmac: Add MAC related callbacks for XGMAC2") Signed-off-by: Rohan G Thomas <[email protected]> Reviewed-by: Matthew Gerlach <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 24be090 commit 4f23382

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -203,10 +203,6 @@ static void dwxgmac2_dma_rx_mode(struct stmmac_priv *priv, void __iomem *ioaddr,
203203
}
204204

205205
writel(value, ioaddr + XGMAC_MTL_RXQ_OPMODE(channel));
206-
207-
/* Enable MTL RX overflow */
208-
value = readl(ioaddr + XGMAC_MTL_QINTEN(channel));
209-
writel(value | XGMAC_RXOIE, ioaddr + XGMAC_MTL_QINTEN(channel));
210206
}
211207

212208
static void dwxgmac2_dma_tx_mode(struct stmmac_priv *priv, void __iomem *ioaddr,

0 commit comments

Comments
 (0)