spi: spi-mux: Fix coverity issue, unchecked return value

sperezglz · broonie · commit 5a5fc308418a · 2025-03-16T23:34:25.000Z
The return value of spi_setup() is not captured within spi_mux_select() and it is assumed to be always success. CID: 1638374 Signed-off-by: Sergio Perez Gonzalez <sperezglz@gmail.com> Link: https://patch.msgid.link/20250316054651.13242-1-sperezglz@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/drivers/spi/spi-mux.c b/drivers/spi/spi-mux.c
@@ -68,9 +68,7 @@ static int spi_mux_select(struct spi_device *spi)
 
 	priv->current_cs = spi_get_chipselect(spi, 0);
 
-	spi_setup(priv->spi);
-
-	return 0;
+	return spi_setup(priv->spi);
 }
 
 static int spi_mux_setup(struct spi_device *spi)

Original file line number	Diff line number	Diff line change
`@@ -68,9 +68,7 @@ static int spi_mux_select(struct spi_device *spi)`
`68`	`68`
`69`	`69`	`priv->current_cs = spi_get_chipselect(spi, 0);`
`70`	`70`
`71`		`- spi_setup(priv->spi);`
`72`		`-`
`73`		`- return 0;`
	`71`	`+ return spi_setup(priv->spi);`
`74`	`72`	`}`
`75`	`73`
`76`	`74`	`static int spi_mux_setup(struct spi_device *spi)`