Skip to content

Commit 5d3bb77

Browse files
committed
erofs: support multi-page folios for erofs_bread()
If the requested page is part of the previous multi-page folio, there is no need to call read_mapping_folio() again. Also, get rid of the remaining one of page->index [1] in our codebase. [1] https://lore.kernel.org/r/[email protected] Cc: Matthew Wilcox <[email protected]> Reviewed-by: Chao Yu <[email protected]> Signed-off-by: Gao Xiang <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 684b290 commit 5d3bb77

File tree

1 file changed

+12
-18
lines changed

1 file changed

+12
-18
lines changed

fs/erofs/data.c

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -21,38 +21,32 @@ void erofs_put_metabuf(struct erofs_buf *buf)
2121
if (!buf->page)
2222
return;
2323
erofs_unmap_metabuf(buf);
24-
put_page(buf->page);
24+
folio_put(page_folio(buf->page));
2525
buf->page = NULL;
2626
}
2727

28-
/*
29-
* Derive the block size from inode->i_blkbits to make compatible with
30-
* anonymous inode in fscache mode.
31-
*/
3228
void *erofs_bread(struct erofs_buf *buf, erofs_off_t offset,
3329
enum erofs_kmap_type type)
3430
{
3531
pgoff_t index = offset >> PAGE_SHIFT;
36-
struct page *page = buf->page;
37-
struct folio *folio;
38-
unsigned int nofs_flag;
32+
struct folio *folio = NULL;
3933

40-
if (!page || page->index != index) {
34+
if (buf->page) {
35+
folio = page_folio(buf->page);
36+
if (folio_file_page(folio, index) != buf->page)
37+
erofs_unmap_metabuf(buf);
38+
}
39+
if (!folio || !folio_contains(folio, index)) {
4140
erofs_put_metabuf(buf);
42-
43-
nofs_flag = memalloc_nofs_save();
44-
folio = read_cache_folio(buf->mapping, index, NULL, NULL);
45-
memalloc_nofs_restore(nofs_flag);
41+
folio = read_mapping_folio(buf->mapping, index, NULL);
4642
if (IS_ERR(folio))
4743
return folio;
48-
49-
/* should already be PageUptodate, no need to lock page */
50-
page = folio_file_page(folio, index);
51-
buf->page = page;
5244
}
45+
buf->page = folio_file_page(folio, index);
46+
5347
if (buf->kmap_type == EROFS_NO_KMAP) {
5448
if (type == EROFS_KMAP)
55-
buf->base = kmap_local_page(page);
49+
buf->base = kmap_local_page(buf->page);
5650
buf->kmap_type = type;
5751
} else if (buf->kmap_type != type) {
5852
DBG_BUGON(1);

0 commit comments

Comments
 (0)