Commit 62607d0
committed
sched_ext: Use sched_clock_cpu() instead of rq_clock_task() in touch_core_sched()
Since 3cf78c5 ("sched_ext: Unpin and repin rq lock from
balance_scx()"), sched_ext's balance path terminates rq_pin in the outermost
function. This is simpler and in line with what other balance functions are
doing but it loses control over rq->clock_update_flags which makes
assert_clock_udpated() trigger if other CPUs pins the rq lock.
The only place this matters is touch_core_sched() which uses the timestamp
to order tasks from sibling rq's. Switch to sched_clock_cpu(). Later, it may
be better to use per-core dispatch sequence number.
v2: Use sched_clock_cpu() instead of ktime_get_ns() per David.
Signed-off-by: Tejun Heo <[email protected]>
Fixes: 3cf78c5 ("sched_ext: Unpin and repin rq lock from balance_scx()")
Acked-by: David Vernet <[email protected]>
Cc: Peter Zijlstra <[email protected]>1 parent 0366017 commit 62607d0
1 file changed
+6
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1453 | 1453 | | |
1454 | 1454 | | |
1455 | 1455 | | |
| 1456 | + | |
| 1457 | + | |
1456 | 1458 | | |
1457 | 1459 | | |
1458 | 1460 | | |
1459 | 1461 | | |
| 1462 | + | |
| 1463 | + | |
| 1464 | + | |
1460 | 1465 | | |
1461 | 1466 | | |
1462 | | - | |
| 1467 | + | |
1463 | 1468 | | |
1464 | 1469 | | |
1465 | 1470 | | |
| |||
1476 | 1481 | | |
1477 | 1482 | | |
1478 | 1483 | | |
1479 | | - | |
1480 | 1484 | | |
1481 | 1485 | | |
1482 | 1486 | | |
| |||
0 commit comments