Skip to content

Commit 65a5520

Browse files
author
Marc Zyngier
committed
arm64: smp: Fix pNMI setup after GICv5 rework
Breno reports that pNMIs are not behaving the way they should since they were reworked for GICv5. Turns out we feed the IRQ number to the pNMI helper instead of the IPI number -- not a good idea. Fix it by providing the correct number (duh). Fixes: ba1004f ("arm64: smp: Support non-SGIs for IPIs") Reported-by: Breno Leitao <[email protected]> Suggested-by: Lorenzo Pieralisi <[email protected]> Signed-off-by: Marc Zyngier <[email protected]>
1 parent 53bb952 commit 65a5520

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/arm64/kernel/smp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1093,7 +1093,7 @@ static void ipi_setup_sgi(int ipi)
10931093

10941094
irq = ipi_irq_base + ipi;
10951095

1096-
if (ipi_should_be_nmi(irq)) {
1096+
if (ipi_should_be_nmi(ipi)) {
10971097
err = request_percpu_nmi(irq, ipi_handler, "IPI", &irq_stat);
10981098
WARN(err, "Could not request IRQ %d as NMI, err=%d\n", irq, err);
10991099
} else {

0 commit comments

Comments
 (0)