net: openvswitch: fix nested key length validation in the set() action

It's not safe to access nla_len(ovs_key) if the data is smaller than
the netlink header.  Check that the attribute is OK first.

Fixes: ccb1352 ("net: Add Open vSwitch kernel components.")
Reported-by: [email protected]
Closes: https://syzkaller.appspot.com/bug?extid=b07a9da40df1576b8048
Tested-by: [email protected]
Signed-off-by: Ilya Maximets <[email protected]>
Reviewed-by: Eelco Chaudron <[email protected]>
Acked-by: Aaron Conole <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>

Author: igsilya

net/openvswitch/flow_netlink.c

@@ -2876,7 +2876,8 @@ static int validate_set(const struct nlattr *a,
 	size_t key_len;
 
 	/* There can be only one key in a action */
-	if (nla_total_size(nla_len(ovs_key)) != nla_len(a))
+	if (!nla_ok(ovs_key, nla_len(a)) ||
+	    nla_total_size(nla_len(ovs_key)) != nla_len(a))
 		return -EINVAL;
 
 	key_len = nla_len(ovs_key);