Skip to content

Commit 67d4b2c

Browse files
Uwe Kleine-Königchanwoochoi
authored andcommitted
extcon: intel-cht-wc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Link: https://lore.kernel.org/lkml/87f0b8f158565cb9ea68b42db2bb018f82a7ee27.1708876186.git.u.kleine-koenig@pengutronix.de/ Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Chanwoo Choi <[email protected]>
1 parent b2da7e2 commit 67d4b2c

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/extcon/extcon-intel-cht-wc.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -617,13 +617,11 @@ static int cht_wc_extcon_probe(struct platform_device *pdev)
617617
return ret;
618618
}
619619

620-
static int cht_wc_extcon_remove(struct platform_device *pdev)
620+
static void cht_wc_extcon_remove(struct platform_device *pdev)
621621
{
622622
struct cht_wc_extcon_data *ext = platform_get_drvdata(pdev);
623623

624624
cht_wc_extcon_sw_control(ext, false);
625-
626-
return 0;
627625
}
628626

629627
static const struct platform_device_id cht_wc_extcon_table[] = {
@@ -634,7 +632,7 @@ MODULE_DEVICE_TABLE(platform, cht_wc_extcon_table);
634632

635633
static struct platform_driver cht_wc_extcon_driver = {
636634
.probe = cht_wc_extcon_probe,
637-
.remove = cht_wc_extcon_remove,
635+
.remove_new = cht_wc_extcon_remove,
638636
.id_table = cht_wc_extcon_table,
639637
.driver = {
640638
.name = "cht_wcove_pwrsrc",

0 commit comments

Comments
 (0)