Skip to content

Commit 67e781f

Browse files
Jiri Slaby (SUSE)gregkh
authored andcommitted
tty: n_tty: drop n_tty_trace()
This n_tty_trace() is an always disabled debugging macro. It comes from commit 32f1352 ("n_tty: Line copy to user buffer in canonical mode"). Drop it as it is dead for over a decade. Signed-off-by: Jiri Slaby (SUSE) <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent e287d64 commit 67e781f

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

drivers/tty/n_tty.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,6 @@
8181
#define ECHO_BLOCK 256
8282
#define ECHO_DISCARD_WATERMARK N_TTY_BUF_SIZE - (ECHO_BLOCK + 32)
8383

84-
85-
#undef N_TTY_TRACE
86-
#ifdef N_TTY_TRACE
87-
# define n_tty_trace(f, args...) trace_printk(f, ##args)
88-
#else
89-
# define n_tty_trace(f, args...) no_printk(f, ##args)
90-
#endif
91-
9284
struct n_tty_data {
9385
/* producer-published */
9486
size_t read_head;
@@ -2026,9 +2018,6 @@ static bool canon_copy_from_read_buf(const struct tty_struct *tty, u8 **kbp,
20262018
tail = MASK(ldata->read_tail);
20272019
size = min_t(size_t, tail + n, N_TTY_BUF_SIZE);
20282020

2029-
n_tty_trace("%s: nr:%zu tail:%zu n:%zu size:%zu\n",
2030-
__func__, *nr, tail, n, size);
2031-
20322021
eol = find_next_bit(ldata->read_flags, size, tail);
20332022
more = n - (size - tail);
20342023
if (eol == N_TTY_BUF_SIZE && more) {
@@ -2046,9 +2035,6 @@ static bool canon_copy_from_read_buf(const struct tty_struct *tty, u8 **kbp,
20462035
if (!found || read_buf(ldata, eol) != __DISABLED_CHAR)
20472036
n = c;
20482037

2049-
n_tty_trace("%s: eol:%zu found:%d n:%zu c:%zu tail:%zu more:%zu\n",
2050-
__func__, eol, found, n, c, tail, more);
2051-
20522038
tty_copy(tty, *kbp, tail, n);
20532039
*kbp += n;
20542040
*nr -= n;

0 commit comments

Comments
 (0)