mtd: rawnand: hynix: fixed typo

ProjectMutilation · miquelraynal · commit 6819db94e1cd · 2024-03-25T11:20:37.000+01:00
The function hynix_nand_rr_init() should probably return an error code. Judging by the usage, it seems that the return code is passed up the call stack. Right now, it always returns 0 and the function hynix_nand_cleanup() in hynix_nand_init() has never been called. Found by RASU JSC and Linux Verification Center (linuxtesting.org) Fixes: 626994e ("mtd: nand: hynix: Add read-retry support for 1x nm MLC NANDs") Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20240313102721.1991299-1-korotkov.maxim.s@gmail.com
diff --git a/drivers/mtd/nand/raw/nand_hynix.c b/drivers/mtd/nand/raw/nand_hynix.c
@@ -401,7 +401,7 @@ static int hynix_nand_rr_init(struct nand_chip *chip)
 	if (ret)
 		pr_warn("failed to initialize read-retry infrastructure");
 
-	return 0;
+	return ret;
 }
 
 static void hynix_nand_extract_oobsize(struct nand_chip *chip,

Original file line number	Diff line number	Diff line change
`@@ -401,7 +401,7 @@ static int hynix_nand_rr_init(struct nand_chip *chip)`
`401`	`401`	`if (ret)`
`402`	`402`	`pr_warn("failed to initialize read-retry infrastructure");`
`403`	`403`
`404`		`- return 0;`
	`404`	`+ return ret;`
`405`	`405`	`}`
`406`	`406`
`407`	`407`	`static void hynix_nand_extract_oobsize(struct nand_chip *chip,`