Skip to content

Commit 6dbcbcf

Browse files
Linu CherianSuzuki K Poulose
authored andcommitted
coresight: tmc: Enable panic sync handling
- Get reserved region from device tree node for metadata - Define metadata format for TMC - Add TMC ETR panic sync handler that syncs register snapshot to metadata region - Add TMC ETF panic sync handler that syncs register snapshot to metadata region and internal SRAM to reserved trace buffer region. Signed-off-by: Linu Cherian <[email protected]> Reviewed-by: James Clark <[email protected]> Signed-off-by: Suzuki K Poulose <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 46006ce commit 6dbcbcf

File tree

4 files changed

+233
-0
lines changed

4 files changed

+233
-0
lines changed

drivers/hwtracing/coresight/coresight-tmc-core.c

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -444,6 +444,20 @@ static void tmc_get_reserved_region(struct device *parent)
444444

445445
drvdata->resrv_buf.paddr = res.start;
446446
drvdata->resrv_buf.size = resource_size(&res);
447+
448+
if (of_tmc_get_reserved_resource_by_name(parent, "metadata", &res))
449+
return;
450+
451+
drvdata->crash_mdata.vaddr = memremap(res.start,
452+
resource_size(&res),
453+
MEMREMAP_WC);
454+
if (IS_ERR_OR_NULL(drvdata->crash_mdata.vaddr)) {
455+
dev_err(parent, "Metadata memory mapping failed\n");
456+
return;
457+
}
458+
459+
drvdata->crash_mdata.paddr = res.start;
460+
drvdata->crash_mdata.size = resource_size(&res);
447461
}
448462

449463
/* Detect and initialise the capabilities of a TMC ETR */

drivers/hwtracing/coresight/coresight-tmc-etf.c

Lines changed: 80 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -590,6 +590,81 @@ static unsigned long tmc_update_etf_buffer(struct coresight_device *csdev,
590590
return to_read;
591591
}
592592

593+
static int tmc_panic_sync_etf(struct coresight_device *csdev)
594+
{
595+
u32 val;
596+
struct tmc_crash_metadata *mdata;
597+
struct tmc_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent);
598+
599+
mdata = (struct tmc_crash_metadata *)drvdata->crash_mdata.vaddr;
600+
601+
/* Make sure we have valid reserved memory */
602+
if (!tmc_has_reserved_buffer(drvdata) ||
603+
!tmc_has_crash_mdata_buffer(drvdata))
604+
return 0;
605+
606+
tmc_crashdata_set_invalid(drvdata);
607+
608+
CS_UNLOCK(drvdata->base);
609+
610+
/* Proceed only if ETF is enabled or configured as sink */
611+
val = readl(drvdata->base + TMC_CTL);
612+
if (!(val & TMC_CTL_CAPT_EN))
613+
goto out;
614+
val = readl(drvdata->base + TMC_MODE);
615+
if (val != TMC_MODE_CIRCULAR_BUFFER)
616+
goto out;
617+
618+
val = readl(drvdata->base + TMC_FFSR);
619+
/* Do manual flush and stop only if its not auto-stopped */
620+
if (!(val & TMC_FFSR_FT_STOPPED)) {
621+
dev_dbg(&csdev->dev,
622+
"%s: Triggering manual flush\n", __func__);
623+
tmc_flush_and_stop(drvdata);
624+
} else
625+
tmc_wait_for_tmcready(drvdata);
626+
627+
/* Sync registers from hardware to metadata region */
628+
mdata->tmc_sts = readl(drvdata->base + TMC_STS);
629+
mdata->tmc_mode = readl(drvdata->base + TMC_MODE);
630+
mdata->tmc_ffcr = readl(drvdata->base + TMC_FFCR);
631+
mdata->tmc_ffsr = readl(drvdata->base + TMC_FFSR);
632+
633+
/* Sync Internal SRAM to reserved trace buffer region */
634+
drvdata->buf = drvdata->resrv_buf.vaddr;
635+
tmc_etb_dump_hw(drvdata);
636+
/* Store as per RSZ register convention */
637+
mdata->tmc_ram_size = drvdata->len >> 2;
638+
639+
/* Other fields for processing trace buffer reads */
640+
mdata->tmc_rrp = 0;
641+
mdata->tmc_dba = 0;
642+
mdata->tmc_rwp = drvdata->len;
643+
mdata->trace_paddr = drvdata->resrv_buf.paddr;
644+
645+
mdata->version = CS_CRASHDATA_VERSION;
646+
647+
/*
648+
* Make sure all previous writes are ordered,
649+
* before we mark valid
650+
*/
651+
dmb(sy);
652+
mdata->valid = true;
653+
/*
654+
* Below order need to maintained, since crc of metadata
655+
* is dependent on first
656+
*/
657+
mdata->crc32_tdata = find_crash_tracedata_crc(drvdata, mdata);
658+
mdata->crc32_mdata = find_crash_metadata_crc(mdata);
659+
660+
tmc_disable_hw(drvdata);
661+
662+
dev_dbg(&csdev->dev, "%s: success\n", __func__);
663+
out:
664+
CS_UNLOCK(drvdata->base);
665+
return 0;
666+
}
667+
593668
static const struct coresight_ops_sink tmc_etf_sink_ops = {
594669
.enable = tmc_enable_etf_sink,
595670
.disable = tmc_disable_etf_sink,
@@ -603,13 +678,18 @@ static const struct coresight_ops_link tmc_etf_link_ops = {
603678
.disable = tmc_disable_etf_link,
604679
};
605680

681+
static const struct coresight_ops_panic tmc_etf_sync_ops = {
682+
.sync = tmc_panic_sync_etf,
683+
};
684+
606685
const struct coresight_ops tmc_etb_cs_ops = {
607686
.sink_ops = &tmc_etf_sink_ops,
608687
};
609688

610689
const struct coresight_ops tmc_etf_cs_ops = {
611690
.sink_ops = &tmc_etf_sink_ops,
612691
.link_ops = &tmc_etf_link_ops,
692+
.panic_ops = &tmc_etf_sync_ops,
613693
};
614694

615695
int tmc_read_prepare_etb(struct tmc_drvdata *drvdata)

drivers/hwtracing/coresight/coresight-tmc-etr.c

Lines changed: 73 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1814,6 +1814,74 @@ static int tmc_disable_etr_sink(struct coresight_device *csdev)
18141814
return 0;
18151815
}
18161816

1817+
static int tmc_panic_sync_etr(struct coresight_device *csdev)
1818+
{
1819+
u32 val;
1820+
struct tmc_crash_metadata *mdata;
1821+
struct tmc_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent);
1822+
1823+
mdata = (struct tmc_crash_metadata *)drvdata->crash_mdata.vaddr;
1824+
1825+
if (!drvdata->etr_buf)
1826+
return 0;
1827+
1828+
/* Being in RESRV mode implies valid reserved memory as well */
1829+
if (drvdata->etr_buf->mode != ETR_MODE_RESRV)
1830+
return 0;
1831+
1832+
if (!tmc_has_crash_mdata_buffer(drvdata))
1833+
return 0;
1834+
1835+
CS_UNLOCK(drvdata->base);
1836+
1837+
/* Proceed only if ETR is enabled */
1838+
val = readl(drvdata->base + TMC_CTL);
1839+
if (!(val & TMC_CTL_CAPT_EN))
1840+
goto out;
1841+
1842+
val = readl(drvdata->base + TMC_FFSR);
1843+
/* Do manual flush and stop only if its not auto-stopped */
1844+
if (!(val & TMC_FFSR_FT_STOPPED)) {
1845+
dev_dbg(&csdev->dev,
1846+
"%s: Triggering manual flush\n", __func__);
1847+
tmc_flush_and_stop(drvdata);
1848+
} else
1849+
tmc_wait_for_tmcready(drvdata);
1850+
1851+
/* Sync registers from hardware to metadata region */
1852+
mdata->tmc_ram_size = readl(drvdata->base + TMC_RSZ);
1853+
mdata->tmc_sts = readl(drvdata->base + TMC_STS);
1854+
mdata->tmc_mode = readl(drvdata->base + TMC_MODE);
1855+
mdata->tmc_ffcr = readl(drvdata->base + TMC_FFCR);
1856+
mdata->tmc_ffsr = readl(drvdata->base + TMC_FFSR);
1857+
mdata->tmc_rrp = tmc_read_rrp(drvdata);
1858+
mdata->tmc_rwp = tmc_read_rwp(drvdata);
1859+
mdata->tmc_dba = tmc_read_dba(drvdata);
1860+
mdata->trace_paddr = drvdata->resrv_buf.paddr;
1861+
mdata->version = CS_CRASHDATA_VERSION;
1862+
1863+
/*
1864+
* Make sure all previous writes are ordered,
1865+
* before we mark valid
1866+
*/
1867+
dmb(sy);
1868+
mdata->valid = true;
1869+
/*
1870+
* Below order need to maintained, since crc of metadata
1871+
* is dependent on first
1872+
*/
1873+
mdata->crc32_tdata = find_crash_tracedata_crc(drvdata, mdata);
1874+
mdata->crc32_mdata = find_crash_metadata_crc(mdata);
1875+
1876+
tmc_disable_hw(drvdata);
1877+
1878+
dev_dbg(&csdev->dev, "%s: success\n", __func__);
1879+
out:
1880+
CS_UNLOCK(drvdata->base);
1881+
1882+
return 0;
1883+
}
1884+
18171885
static const struct coresight_ops_sink tmc_etr_sink_ops = {
18181886
.enable = tmc_enable_etr_sink,
18191887
.disable = tmc_disable_etr_sink,
@@ -1822,8 +1890,13 @@ static const struct coresight_ops_sink tmc_etr_sink_ops = {
18221890
.free_buffer = tmc_free_etr_buffer,
18231891
};
18241892

1893+
static const struct coresight_ops_panic tmc_etr_sync_ops = {
1894+
.sync = tmc_panic_sync_etr,
1895+
};
1896+
18251897
const struct coresight_ops tmc_etr_cs_ops = {
18261898
.sink_ops = &tmc_etr_sink_ops,
1899+
.panic_ops = &tmc_etr_sync_ops,
18271900
};
18281901

18291902
int tmc_read_prepare_etr(struct tmc_drvdata *drvdata)

drivers/hwtracing/coresight/coresight-tmc.h

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
#include <linux/miscdevice.h>
1313
#include <linux/mutex.h>
1414
#include <linux/refcount.h>
15+
#include <linux/crc32.h>
1516

1617
#define TMC_RSZ 0x004
1718
#define TMC_STS 0x00c
@@ -76,6 +77,9 @@
7677
#define TMC_AXICTL_AXCACHE_OS (0xf << 2)
7778
#define TMC_AXICTL_ARCACHE_OS (0xf << 16)
7879

80+
/* TMC_FFSR - 0x300 */
81+
#define TMC_FFSR_FT_STOPPED BIT(1)
82+
7983
/* TMC_FFCR - 0x304 */
8084
#define TMC_FFCR_FLUSHMAN_BIT 6
8185
#define TMC_FFCR_EN_FMT BIT(0)
@@ -94,6 +98,9 @@
9498

9599
#define TMC_AUTH_NSID_MASK GENMASK(1, 0)
96100

101+
/* Major version 1 Minor version 0 */
102+
#define CS_CRASHDATA_VERSION (1 << 16)
103+
97104
enum tmc_config_type {
98105
TMC_CONFIG_TYPE_ETB,
99106
TMC_CONFIG_TYPE_ETR,
@@ -131,6 +138,25 @@ enum tmc_mem_intf_width {
131138
#define CORESIGHT_SOC_600_ETR_CAPS \
132139
(TMC_ETR_SAVE_RESTORE | TMC_ETR_AXI_ARCACHE)
133140

141+
/* TMC metadata region for ETR and ETF configurations */
142+
struct tmc_crash_metadata {
143+
uint32_t crc32_mdata; /* crc of metadata */
144+
uint32_t crc32_tdata; /* crc of tracedata */
145+
uint32_t version; /* 31:16 Major version, 15:0 Minor version */
146+
uint32_t valid; /* Indicate if this ETF/ETR was enabled */
147+
uint32_t tmc_ram_size; /* Ram Size register */
148+
uint32_t tmc_sts; /* Status register */
149+
uint32_t tmc_mode; /* Mode register */
150+
uint32_t tmc_ffcr; /* Formatter and flush control register */
151+
uint32_t tmc_ffsr; /* Formatter and flush status register */
152+
uint32_t reserved32;
153+
uint64_t tmc_rrp; /* Ram Read pointer register */
154+
uint64_t tmc_rwp; /* Ram Write pointer register */
155+
uint64_t tmc_dba; /* Data buffer address register */
156+
uint64_t trace_paddr; /* Phys address of trace buffer */
157+
uint64_t reserved64[3];
158+
};
159+
134160
enum etr_mode {
135161
ETR_MODE_FLAT, /* Uses contiguous flat buffer */
136162
ETR_MODE_ETR_SG, /* Uses in-built TMC ETR SG mechanism */
@@ -205,6 +231,8 @@ struct tmc_resrv_buf {
205231
* retention (after crash) only when ETR_MODE_RESRV buffer
206232
* mode is enabled. Used by ETF for trace data retention
207233
* (after crash) by default.
234+
* @crash_mdata: Reserved memory for storing tmc crash metadata.
235+
* Used by ETR/ETF.
208236
*/
209237
struct tmc_drvdata {
210238
struct clk *pclk;
@@ -231,6 +259,7 @@ struct tmc_drvdata {
231259
struct etr_buf *sysfs_buf;
232260
struct etr_buf *perf_buf;
233261
struct tmc_resrv_buf resrv_buf;
262+
struct tmc_resrv_buf crash_mdata;
234263
};
235264

236265
struct etr_buf_operations {
@@ -356,6 +385,43 @@ static inline bool tmc_has_reserved_buffer(struct tmc_drvdata *drvdata)
356385
return false;
357386
}
358387

388+
static inline bool tmc_has_crash_mdata_buffer(struct tmc_drvdata *drvdata)
389+
{
390+
if (drvdata->crash_mdata.vaddr &&
391+
drvdata->crash_mdata.size)
392+
return true;
393+
return false;
394+
}
395+
396+
static inline void tmc_crashdata_set_invalid(struct tmc_drvdata *drvdata)
397+
{
398+
struct tmc_crash_metadata *mdata;
399+
400+
mdata = (struct tmc_crash_metadata *)drvdata->crash_mdata.vaddr;
401+
402+
if (tmc_has_crash_mdata_buffer(drvdata))
403+
mdata->valid = false;
404+
}
405+
406+
static inline uint32_t find_crash_metadata_crc(struct tmc_crash_metadata *md)
407+
{
408+
unsigned long crc_size;
409+
410+
crc_size = sizeof(struct tmc_crash_metadata) -
411+
offsetof(struct tmc_crash_metadata, crc32_tdata);
412+
return crc32_le(0, (void *)&md->crc32_tdata, crc_size);
413+
}
414+
415+
static inline uint32_t find_crash_tracedata_crc(struct tmc_drvdata *drvdata,
416+
struct tmc_crash_metadata *md)
417+
{
418+
unsigned long crc_size;
419+
420+
/* Take CRC of configured buffer size to keep it simple */
421+
crc_size = md->tmc_ram_size << 2;
422+
return crc32_le(0, (void *)drvdata->resrv_buf.vaddr, crc_size);
423+
}
424+
359425
struct coresight_device *tmc_etr_get_catu_device(struct tmc_drvdata *drvdata);
360426

361427
void tmc_etr_set_catu_ops(const struct etr_buf_operations *catu);

0 commit comments

Comments
 (0)