Skip to content

Commit 6e3b7e8

Browse files
committed
firmware: microchip: don't unconditionally print validation success
If validation fails, both prints are made. Skip the success one in the failure case. Fixes: ec5b0f1 ("firmware: microchip: add PolarFire SoC Auto Update support") Signed-off-by: Conor Dooley <[email protected]>
1 parent 6b0856e commit 6e3b7e8

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/firmware/microchip/mpfs-auto-update.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,10 +206,12 @@ static int mpfs_auto_update_verify_image(struct fw_upload *fw_uploader)
206206
if (ret | response->resp_status) {
207207
dev_warn(priv->dev, "Verification of Upgrade Image failed!\n");
208208
ret = ret ? ret : -EBADMSG;
209+
goto free_message;
209210
}
210211

211212
dev_info(priv->dev, "Verification of Upgrade Image passed!\n");
212213

214+
free_message:
213215
devm_kfree(priv->dev, message);
214216
free_response:
215217
devm_kfree(priv->dev, response);

0 commit comments

Comments
 (0)