Skip to content

Commit 77678a2

Browse files
krzkbroonie
authored andcommitted
ASoC: qcom: Use snd_soc_substream_to_rtd() for accessing private_data
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent ba2a2c3 commit 77678a2

File tree

8 files changed

+31
-31
lines changed

8 files changed

+31
-31
lines changed

sound/soc/qcom/apq8016_sbc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ static int msm8916_qdsp6_dai_init(struct snd_soc_pcm_runtime *rtd)
192192

193193
static int msm8916_qdsp6_startup(struct snd_pcm_substream *substream)
194194
{
195-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
195+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
196196
struct snd_soc_card *card = rtd->card;
197197
struct apq8016_sbc_data *data = snd_soc_card_get_drvdata(card);
198198
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
@@ -213,7 +213,7 @@ static int msm8916_qdsp6_startup(struct snd_pcm_substream *substream)
213213

214214
static void msm8916_qdsp6_shutdown(struct snd_pcm_substream *substream)
215215
{
216-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
216+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
217217
struct snd_soc_card *card = rtd->card;
218218
struct apq8016_sbc_data *data = snd_soc_card_get_drvdata(card);
219219
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);

sound/soc/qcom/qdsp6/q6apm-dai.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ static int q6apm_dai_open(struct snd_soc_component *component,
331331
struct snd_pcm_substream *substream)
332332
{
333333
struct snd_pcm_runtime *runtime = substream->runtime;
334-
struct snd_soc_pcm_runtime *soc_prtd = substream->private_data;
334+
struct snd_soc_pcm_runtime *soc_prtd = snd_soc_substream_to_rtd(substream);
335335
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(soc_prtd, 0);
336336
struct device *dev = component->dev;
337337
struct q6apm_dai_data *pdata;

sound/soc/qcom/sc7180.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ static int sc7180_startup_realtek_codec(struct snd_soc_pcm_runtime *rtd)
200200

201201
static int sc7180_snd_startup(struct snd_pcm_substream *substream)
202202
{
203-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
203+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
204204
struct snd_soc_card *card = rtd->card;
205205
struct sc7180_snd_data *data = snd_soc_card_get_drvdata(card);
206206
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
@@ -234,7 +234,7 @@ static int sc7180_snd_startup(struct snd_pcm_substream *substream)
234234

235235
static int sc7180_qdsp_snd_startup(struct snd_pcm_substream *substream)
236236
{
237-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
237+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
238238
struct snd_soc_card *card = rtd->card;
239239
struct sc7180_snd_data *data = snd_soc_card_get_drvdata(card);
240240
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
@@ -307,7 +307,7 @@ static int dmic_set(struct snd_kcontrol *kcontrol,
307307

308308
static void sc7180_snd_shutdown(struct snd_pcm_substream *substream)
309309
{
310-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
310+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
311311
struct snd_soc_card *card = rtd->card;
312312
struct sc7180_snd_data *data = snd_soc_card_get_drvdata(card);
313313
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
@@ -334,7 +334,7 @@ static void sc7180_snd_shutdown(struct snd_pcm_substream *substream)
334334

335335
static void sc7180_qdsp_snd_shutdown(struct snd_pcm_substream *substream)
336336
{
337-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
337+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
338338
struct snd_soc_card *card = rtd->card;
339339
struct sc7180_snd_data *data = snd_soc_card_get_drvdata(card);
340340
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
@@ -389,7 +389,7 @@ static int sc7180_adau7002_init(struct snd_soc_pcm_runtime *rtd)
389389

390390
static int sc7180_adau7002_snd_startup(struct snd_pcm_substream *substream)
391391
{
392-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
392+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
393393
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
394394
struct snd_soc_dai *codec_dai = snd_soc_rtd_to_codec(rtd, 0);
395395
struct snd_pcm_runtime *runtime = substream->runtime;

sound/soc/qcom/sc7280.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ static int sc7280_snd_hw_params(struct snd_pcm_substream *substream,
205205
struct snd_pcm_hw_params *params)
206206
{
207207
struct snd_pcm_runtime *runtime = substream->runtime;
208-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
208+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
209209
struct snd_soc_dai *codec_dai;
210210
const struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
211211
struct sc7280_snd_data *pdata = snd_soc_card_get_drvdata(rtd->card);
@@ -237,7 +237,7 @@ static int sc7280_snd_hw_params(struct snd_pcm_substream *substream,
237237

238238
static int sc7280_snd_swr_prepare(struct snd_pcm_substream *substream)
239239
{
240-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
240+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
241241
const struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
242242
struct sc7280_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
243243
struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];
@@ -268,7 +268,7 @@ static int sc7280_snd_swr_prepare(struct snd_pcm_substream *substream)
268268

269269
static int sc7280_snd_prepare(struct snd_pcm_substream *substream)
270270
{
271-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
271+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
272272
const struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
273273

274274
switch (cpu_dai->id) {
@@ -287,7 +287,7 @@ static int sc7280_snd_prepare(struct snd_pcm_substream *substream)
287287

288288
static int sc7280_snd_hw_free(struct snd_pcm_substream *substream)
289289
{
290-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
290+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
291291
struct sc7280_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
292292
const struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
293293
struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];
@@ -312,7 +312,7 @@ static int sc7280_snd_hw_free(struct snd_pcm_substream *substream)
312312

313313
static void sc7280_snd_shutdown(struct snd_pcm_substream *substream)
314314
{
315-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
315+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
316316
struct snd_soc_card *card = rtd->card;
317317
struct sc7280_snd_data *data = snd_soc_card_get_drvdata(card);
318318
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
@@ -339,7 +339,7 @@ static int sc7280_snd_startup(struct snd_pcm_substream *substream)
339339
{
340340
unsigned int fmt = SND_SOC_DAIFMT_CBS_CFS;
341341
unsigned int codec_dai_fmt = SND_SOC_DAIFMT_CBS_CFS;
342-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
342+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
343343
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
344344
struct snd_soc_dai *codec_dai = snd_soc_rtd_to_codec(rtd, 0);
345345
int ret = 0;

sound/soc/qcom/sc8280xp.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ static int sc8280xp_snd_init(struct snd_soc_pcm_runtime *rtd)
5050

5151
static void sc8280xp_snd_shutdown(struct snd_pcm_substream *substream)
5252
{
53-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
53+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
5454
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
5555
struct sc8280xp_snd_data *pdata = snd_soc_card_get_drvdata(rtd->card);
5656
struct sdw_stream_runtime *sruntime = pdata->sruntime[cpu_dai->id];
@@ -89,7 +89,7 @@ static int sc8280xp_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
8989
static int sc8280xp_snd_hw_params(struct snd_pcm_substream *substream,
9090
struct snd_pcm_hw_params *params)
9191
{
92-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
92+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
9393
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
9494
struct sc8280xp_snd_data *pdata = snd_soc_card_get_drvdata(rtd->card);
9595

@@ -98,7 +98,7 @@ static int sc8280xp_snd_hw_params(struct snd_pcm_substream *substream,
9898

9999
static int sc8280xp_snd_prepare(struct snd_pcm_substream *substream)
100100
{
101-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
101+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
102102
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
103103
struct sc8280xp_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
104104
struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];
@@ -109,7 +109,7 @@ static int sc8280xp_snd_prepare(struct snd_pcm_substream *substream)
109109

110110
static int sc8280xp_snd_hw_free(struct snd_pcm_substream *substream)
111111
{
112-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
112+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
113113
struct sc8280xp_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
114114
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
115115
struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];

sound/soc/qcom/sdw.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
*/
2222
int qcom_snd_sdw_startup(struct snd_pcm_substream *substream)
2323
{
24-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
24+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
2525
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
2626
struct sdw_stream_runtime *sruntime;
2727
struct snd_soc_dai *codec_dai;
@@ -54,7 +54,7 @@ int qcom_snd_sdw_prepare(struct snd_pcm_substream *substream,
5454
struct sdw_stream_runtime *sruntime,
5555
bool *stream_prepared)
5656
{
57-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
57+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
5858
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
5959
int ret;
6060

@@ -105,7 +105,7 @@ int qcom_snd_sdw_hw_params(struct snd_pcm_substream *substream,
105105
struct snd_pcm_hw_params *params,
106106
struct sdw_stream_runtime **psruntime)
107107
{
108-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
108+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
109109
struct snd_soc_dai *codec_dai;
110110
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
111111
struct sdw_stream_runtime *sruntime;
@@ -135,7 +135,7 @@ EXPORT_SYMBOL_GPL(qcom_snd_sdw_hw_params);
135135
int qcom_snd_sdw_hw_free(struct snd_pcm_substream *substream,
136136
struct sdw_stream_runtime *sruntime, bool *stream_prepared)
137137
{
138-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
138+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
139139
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
140140

141141
switch (cpu_dai->id) {

sound/soc/qcom/sm8250.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
5050
{
5151
unsigned int fmt = SND_SOC_DAIFMT_BP_FP;
5252
unsigned int codec_dai_fmt = SND_SOC_DAIFMT_BC_FC;
53-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
53+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
5454
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
5555
struct snd_soc_dai *codec_dai = snd_soc_rtd_to_codec(rtd, 0);
5656

@@ -72,7 +72,7 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
7272

7373
static void sm2450_snd_shutdown(struct snd_pcm_substream *substream)
7474
{
75-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
75+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
7676
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
7777
struct sm8250_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
7878
struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];
@@ -84,7 +84,7 @@ static void sm2450_snd_shutdown(struct snd_pcm_substream *substream)
8484
static int sm8250_snd_hw_params(struct snd_pcm_substream *substream,
8585
struct snd_pcm_hw_params *params)
8686
{
87-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
87+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
8888
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
8989
struct sm8250_snd_data *pdata = snd_soc_card_get_drvdata(rtd->card);
9090

@@ -93,7 +93,7 @@ static int sm8250_snd_hw_params(struct snd_pcm_substream *substream,
9393

9494
static int sm8250_snd_prepare(struct snd_pcm_substream *substream)
9595
{
96-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
96+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
9797
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
9898
struct sm8250_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
9999
struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];
@@ -104,7 +104,7 @@ static int sm8250_snd_prepare(struct snd_pcm_substream *substream)
104104

105105
static int sm8250_snd_hw_free(struct snd_pcm_substream *substream)
106106
{
107-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
107+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
108108
struct sm8250_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
109109
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
110110
struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];

sound/soc/qcom/x1e80100.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ static int x1e80100_snd_init(struct snd_soc_pcm_runtime *rtd)
3131

3232
static void x1e80100_snd_shutdown(struct snd_pcm_substream *substream)
3333
{
34-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
34+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
3535
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
3636
struct x1e80100_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
3737
struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];
@@ -67,7 +67,7 @@ static int x1e80100_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
6767
static int x1e80100_snd_hw_params(struct snd_pcm_substream *substream,
6868
struct snd_pcm_hw_params *params)
6969
{
70-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
70+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
7171
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
7272
struct x1e80100_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
7373

@@ -76,7 +76,7 @@ static int x1e80100_snd_hw_params(struct snd_pcm_substream *substream,
7676

7777
static int x1e80100_snd_prepare(struct snd_pcm_substream *substream)
7878
{
79-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
79+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
8080
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
8181
struct x1e80100_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
8282
struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];
@@ -87,7 +87,7 @@ static int x1e80100_snd_prepare(struct snd_pcm_substream *substream)
8787

8888
static int x1e80100_snd_hw_free(struct snd_pcm_substream *substream)
8989
{
90-
struct snd_soc_pcm_runtime *rtd = substream->private_data;
90+
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
9191
struct x1e80100_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
9292
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
9393
struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];

0 commit comments

Comments
 (0)