Skip to content

Commit 780c9db

Browse files
ukleinekjic23
authored andcommitted
iio: adc: ad_sigma_delta: Add error checking for ad_sigma_delta_set_channel()
All other calls to ad_sigma_delta_set_channel() in ad_sigma_delta.c check the return value afterwards. Do it for all calls. Signed-off-by: Uwe Kleine-König <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jonathan Cameron <[email protected]>
1 parent 7d33bda commit 780c9db

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/iio/adc/ad_sigma_delta.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,9 @@ int ad_sigma_delta_single_conversion(struct iio_dev *indio_dev,
390390
if (!iio_device_claim_direct(indio_dev))
391391
return -EBUSY;
392392

393-
ad_sigma_delta_set_channel(sigma_delta, chan->address);
393+
ret = ad_sigma_delta_set_channel(sigma_delta, chan->address);
394+
if (ret)
395+
goto out_release;
394396

395397
spi_bus_lock(sigma_delta->spi->controller);
396398
sigma_delta->bus_locked = true;
@@ -431,6 +433,7 @@ int ad_sigma_delta_single_conversion(struct iio_dev *indio_dev,
431433
sigma_delta->keep_cs_asserted = false;
432434
sigma_delta->bus_locked = false;
433435
spi_bus_unlock(sigma_delta->spi->controller);
436+
out_release:
434437
iio_device_release_direct(indio_dev);
435438

436439
if (ret)

0 commit comments

Comments
 (0)