Skip to content

Commit 7a4c93c

Browse files
Dr. David Alan Gilberttdz
authored andcommitted
drm/vboxvideo: Remove unused hgsmi_cursor_position
hgsmi_cursor_position() has been unused since 2018's commit 35f3288 ("staging: vboxvideo: Atomic phase 1: convert cursor to universal plane") Remove it. Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Hans de Goede <[email protected]> Signed-off-by: Thomas Zimmermann <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 77f183d commit 7a4c93c

File tree

2 files changed

+0
-39
lines changed

2 files changed

+0
-39
lines changed

drivers/gpu/drm/vboxvideo/hgsmi_base.c

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -181,40 +181,3 @@ int hgsmi_update_pointer_shape(struct gen_pool *ctx, u32 flags,
181181

182182
return rc;
183183
}
184-
185-
/**
186-
* hgsmi_cursor_position - Report the guest cursor position. The host may
187-
* wish to use this information to re-position its
188-
* own cursor (though this is currently unlikely).
189-
* The current host cursor position is returned.
190-
* Return: 0 or negative errno value.
191-
* @ctx: The context containing the heap used.
192-
* @report_position: Are we reporting a position?
193-
* @x: Guest cursor X position.
194-
* @y: Guest cursor Y position.
195-
* @x_host: Host cursor X position is stored here. Optional.
196-
* @y_host: Host cursor Y position is stored here. Optional.
197-
*/
198-
int hgsmi_cursor_position(struct gen_pool *ctx, bool report_position,
199-
u32 x, u32 y, u32 *x_host, u32 *y_host)
200-
{
201-
struct vbva_cursor_position *p;
202-
203-
p = hgsmi_buffer_alloc(ctx, sizeof(*p), HGSMI_CH_VBVA,
204-
VBVA_CURSOR_POSITION);
205-
if (!p)
206-
return -ENOMEM;
207-
208-
p->report_position = report_position;
209-
p->x = x;
210-
p->y = y;
211-
212-
hgsmi_buffer_submit(ctx, p);
213-
214-
*x_host = p->x;
215-
*y_host = p->y;
216-
217-
hgsmi_buffer_free(ctx, p);
218-
219-
return 0;
220-
}

drivers/gpu/drm/vboxvideo/vboxvideo_guest.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ int hgsmi_query_conf(struct gen_pool *ctx, u32 index, u32 *value_ret);
3434
int hgsmi_update_pointer_shape(struct gen_pool *ctx, u32 flags,
3535
u32 hot_x, u32 hot_y, u32 width, u32 height,
3636
u8 *pixels, u32 len);
37-
int hgsmi_cursor_position(struct gen_pool *ctx, bool report_position,
38-
u32 x, u32 y, u32 *x_host, u32 *y_host);
3937

4038
bool vbva_enable(struct vbva_buf_ctx *vbva_ctx, struct gen_pool *ctx,
4139
struct vbva_buffer *vbva, s32 screen);

0 commit comments

Comments
 (0)