Skip to content

Commit 7af5b9e

Browse files
Dan Carpenterbebarino
authored andcommitted
clk: ti: fix double free in of_ti_divider_clk_setup()
The "div" pointer is freed in _register_divider() and again in of_ti_divider_clk_setup(). Delete the free in _register_divider() Fixes: fbbc185 ("clk: ti: divider: cleanup _register_divider and ti_clk_get_div_table") Signed-off-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Tony Lindgren <[email protected]> Signed-off-by: Stephen Boyd <[email protected]>
1 parent a5d14f8 commit 7af5b9e

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

drivers/clk/ti/divider.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,6 @@ static struct clk *_register_divider(struct device_node *node,
309309
u32 flags,
310310
struct clk_omap_divider *div)
311311
{
312-
struct clk *clk;
313312
struct clk_init_data init;
314313
const char *parent_name;
315314
const char *name;
@@ -326,12 +325,7 @@ static struct clk *_register_divider(struct device_node *node,
326325
div->hw.init = &init;
327326

328327
/* register the clock */
329-
clk = of_ti_clk_register(node, &div->hw, name);
330-
331-
if (IS_ERR(clk))
332-
kfree(div);
333-
334-
return clk;
328+
return of_ti_clk_register(node, &div->hw, name);
335329
}
336330

337331
int ti_clk_parse_divider_data(int *div_table, int num_dividers, int max_div,

0 commit comments

Comments
 (0)