nvmet: Remove duplicate uuid_copy

mikechristie · keithbusch · commit 7b658153f1b8 · 2025-03-20T16:53:55.000-07:00
We do uuid_copy twice in nvmet_alloc_ctrl so this patch deletes one
of the calls.

Signed-off-by: Mike Christie &lt;michael.christie@oracle.com&gt;
Reviewed-by: Christoph Hellwig &lt;hch@lst.de&gt;
Signed-off-by: Keith Busch &lt;kbusch@kernel.org&gt;
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
@@ -1620,8 +1620,6 @@ struct nvmet_ctrl *nvmet_alloc_ctrl(struct nvmet_alloc_ctrl_args *args)
 	}
 	ctrl->cntlid = ret;
 
-	uuid_copy(&ctrl->hostid, args->hostid);
-
 	/*
 	 * Discovery controllers may use some arbitrary high value
 	 * in order to cleanup stale discovery sessions

Original file line number	Diff line number	Diff line change
`@@ -1620,8 +1620,6 @@ struct nvmet_ctrl nvmet_alloc_ctrl(struct nvmet_alloc_ctrl_args args)`
`1620`	`1620`	`}`
`1621`	`1621`	`ctrl->cntlid = ret;`
`1622`	`1622`
`1623`		`- uuid_copy(&ctrl->hostid, args->hostid);`
`1624`		`-`
`1625`	`1623`	`/*`
`1626`	`1624`	`* Discovery controllers may use some arbitrary high value`
`1627`	`1625`	`* in order to cleanup stale discovery sessions`