Skip to content

Commit 838a871

Browse files
Andy Yanmmind
authored andcommitted
drm/rockchip: vop2: Remove AFBC from TRANSFORM_OFFSET register macro
This TRANSFORM_OFFSET register needs to be configured not only in AFBC mode, but also in tile mode, so remove the AFBC/AFBCD prefix. This also help avoid "exceeds 100 columns" warning from checkpatch. Signed-off-by: Andy Yan <[email protected]> Signed-off-by: Heiko Stuebner <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent ff0b6c0 commit 838a871

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

drivers/gpu/drm/rockchip/rockchip_drm_vop2.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1525,7 +1525,7 @@ static void vop2_plane_atomic_update(struct drm_plane *plane,
15251525
transform_offset = vop2_afbc_transform_offset(pstate, half_block_en);
15261526
vop2_win_write(win, VOP2_WIN_AFBC_HDR_PTR, yrgb_mst);
15271527
vop2_win_write(win, VOP2_WIN_AFBC_PIC_SIZE, act_info);
1528-
vop2_win_write(win, VOP2_WIN_AFBC_TRANSFORM_OFFSET, transform_offset);
1528+
vop2_win_write(win, VOP2_WIN_TRANSFORM_OFFSET, transform_offset);
15291529
vop2_win_write(win, VOP2_WIN_AFBC_PIC_OFFSET, ((src->x1 >> 16) | src->y1));
15301530
vop2_win_write(win, VOP2_WIN_AFBC_DSP_OFFSET, (dest->x1 | (dest->y1 << 16)));
15311531
vop2_win_write(win, VOP2_WIN_AFBC_PIC_VIR_WIDTH, stride);
@@ -1536,7 +1536,7 @@ static void vop2_plane_atomic_update(struct drm_plane *plane,
15361536
} else {
15371537
if (vop2_cluster_window(win)) {
15381538
vop2_win_write(win, VOP2_WIN_AFBC_ENABLE, 0);
1539-
vop2_win_write(win, VOP2_WIN_AFBC_TRANSFORM_OFFSET, 0);
1539+
vop2_win_write(win, VOP2_WIN_TRANSFORM_OFFSET, 0);
15401540
}
15411541

15421542
vop2_win_write(win, VOP2_WIN_YRGB_VIR, DIV_ROUND_UP(fb->pitches[0], 4));
@@ -3460,7 +3460,7 @@ static const struct reg_field vop2_cluster_regs[VOP2_WIN_MAX_REG] = {
34603460
[VOP2_WIN_AFBC_TILE_NUM] = REG_FIELD(RK3568_CLUSTER_WIN_AFBCD_VIR_WIDTH, 16, 31),
34613461
[VOP2_WIN_AFBC_PIC_OFFSET] = REG_FIELD(RK3568_CLUSTER_WIN_AFBCD_PIC_OFFSET, 0, 31),
34623462
[VOP2_WIN_AFBC_DSP_OFFSET] = REG_FIELD(RK3568_CLUSTER_WIN_AFBCD_DSP_OFFSET, 0, 31),
3463-
[VOP2_WIN_AFBC_TRANSFORM_OFFSET] = REG_FIELD(RK3568_CLUSTER_WIN_AFBCD_TRANSFORM_OFFSET, 0, 31),
3463+
[VOP2_WIN_TRANSFORM_OFFSET] = REG_FIELD(RK3568_CLUSTER_WIN_TRANSFORM_OFFSET, 0, 31),
34643464
[VOP2_WIN_AFBC_ROTATE_90] = REG_FIELD(RK3568_CLUSTER_WIN_AFBCD_ROTATE_MODE, 0, 0),
34653465
[VOP2_WIN_AFBC_ROTATE_270] = REG_FIELD(RK3568_CLUSTER_WIN_AFBCD_ROTATE_MODE, 1, 1),
34663466
[VOP2_WIN_XMIRROR] = REG_FIELD(RK3568_CLUSTER_WIN_AFBCD_ROTATE_MODE, 2, 2),
@@ -3559,7 +3559,7 @@ static const struct reg_field vop2_esmart_regs[VOP2_WIN_MAX_REG] = {
35593559
[VOP2_WIN_AFBC_PIC_OFFSET] = { .reg = 0xffffffff },
35603560
[VOP2_WIN_AFBC_PIC_SIZE] = { .reg = 0xffffffff },
35613561
[VOP2_WIN_AFBC_DSP_OFFSET] = { .reg = 0xffffffff },
3562-
[VOP2_WIN_AFBC_TRANSFORM_OFFSET] = { .reg = 0xffffffff },
3562+
[VOP2_WIN_TRANSFORM_OFFSET] = { .reg = 0xffffffff },
35633563
[VOP2_WIN_AFBC_HDR_PTR] = { .reg = 0xffffffff },
35643564
[VOP2_WIN_AFBC_HALF_BLOCK_EN] = { .reg = 0xffffffff },
35653565
[VOP2_WIN_AFBC_ROTATE_270] = { .reg = 0xffffffff },

drivers/gpu/drm/rockchip/rockchip_drm_vop2.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ enum vop2_win_regs {
118118
VOP2_WIN_AFBC_PIC_OFFSET,
119119
VOP2_WIN_AFBC_PIC_SIZE,
120120
VOP2_WIN_AFBC_DSP_OFFSET,
121-
VOP2_WIN_AFBC_TRANSFORM_OFFSET,
121+
VOP2_WIN_TRANSFORM_OFFSET,
122122
VOP2_WIN_AFBC_HDR_PTR,
123123
VOP2_WIN_AFBC_HALF_BLOCK_EN,
124124
VOP2_WIN_AFBC_ROTATE_270,
@@ -335,7 +335,7 @@ enum dst_factor_mode {
335335
#define RK3568_CLUSTER_WIN_DSP_INFO 0x24
336336
#define RK3568_CLUSTER_WIN_DSP_ST 0x28
337337
#define RK3568_CLUSTER_WIN_SCL_FACTOR_YRGB 0x30
338-
#define RK3568_CLUSTER_WIN_AFBCD_TRANSFORM_OFFSET 0x3C
338+
#define RK3568_CLUSTER_WIN_TRANSFORM_OFFSET 0x3C
339339
#define RK3568_CLUSTER_WIN_AFBCD_OUTPUT_CTRL 0x50
340340
#define RK3568_CLUSTER_WIN_AFBCD_ROTATE_MODE 0x54
341341
#define RK3568_CLUSTER_WIN_AFBCD_HDR_PTR 0x58

0 commit comments

Comments
 (0)