Skip to content

Commit 84fa186

Browse files
esunjmmind
authored andcommitted
arm64: dts: rockchip: use codec as clock master on px30-ringneck-haikou
If the codec is not the clock master, the MCLK needs to be synchronous to both I2S_SCL ans I2S_LRCLK. We do not have that on Haikou, causing distorted audio. Before: Running an audio test script on Ringneck, 1kHz output sine wave is not stable and shows distortion. After: 10h audio test script loop failed only one time. That is 0.00014% failure rate. Cc: [email protected] Fixes: c484cf9 ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard") Signed-off-by: Ermin Sunj <[email protected]> Signed-off-by: Jakob Unterwurzacher <[email protected]> Link: https://lore.kernel.org/r/20230907151725.198347-1-jakob.unterwurzacher@theobroma-systems.com Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 0bb80ec commit 84fa186

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,15 @@
6868
simple-audio-card,format = "i2s";
6969
simple-audio-card,name = "Haikou,I2S-codec";
7070
simple-audio-card,mclk-fs = <512>;
71+
simple-audio-card,frame-master = <&sgtl5000_codec>;
72+
simple-audio-card,bitclock-master = <&sgtl5000_codec>;
7173

72-
simple-audio-card,codec {
74+
sgtl5000_codec: simple-audio-card,codec {
7375
clocks = <&sgtl5000_clk>;
7476
sound-dai = <&sgtl5000>;
7577
};
7678

7779
simple-audio-card,cpu {
78-
bitclock-master;
79-
frame-master;
8080
sound-dai = <&i2s0_8ch>;
8181
};
8282
};

0 commit comments

Comments
 (0)