Skip to content

Commit 89f0add

Browse files
Dan Carpentertiwai
authored andcommitted
ALSA: usb-audio: Fix size validation in convert_chmap_v3()
The "p" pointer is void so sizeof(*p) is 1. The intent was to check sizeof(*cs_desc), which is 3, instead. Fixes: ecfd411 ("ALSA: usb-audio: Validate UAC3 cluster segment descriptors") Signed-off-by: Dan Carpenter <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent c0ed3c2 commit 89f0add

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/usb/stream.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ snd_pcm_chmap_elem *convert_chmap_v3(struct uac3_cluster_header_descriptor
349349
u16 cs_len;
350350
u8 cs_type;
351351

352-
if (len < sizeof(*p))
352+
if (len < sizeof(*cs_desc))
353353
break;
354354
cs_len = le16_to_cpu(cs_desc->wLength);
355355
if (len < cs_len)

0 commit comments

Comments
 (0)