Commit 8c7a6ef
ipv4: route: fix drop reason being overridden in ip_route_input_slow
When jumping to 'martian_destination' a drop reason is always set but
that label falls-through the 'e_nobufs' one, overriding the value.
The behavior was introduced by the mentioned commit. The logic went
from,
goto martian_destination;
...
martian_destination:
...
e_inval:
err = -EINVAL;
goto out;
e_nobufs:
err = -ENOBUFS;
goto out;
to,
reason = ...;
goto martian_destination;
...
martian_destination:
...
e_nobufs:
reason = SKB_DROP_REASON_NOMEM;
goto out;
A 'goto out' is clearly missing now after 'martian_destination' to avoid
overriding the drop reason.
Fixes: 5b92112 ("net: ip: make ip_route_input_slow() return drop reasons")
Reported-by: Sabrina Dubroca <[email protected]>
Cc: Menglong Dong <[email protected]>
Signed-off-by: Antoine Tenart <[email protected]>
Reviewed-by: Sabrina Dubroca <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>1 parent 03d120f commit 8c7a6ef
1 file changed
+1
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2445 | 2445 | | |
2446 | 2446 | | |
2447 | 2447 | | |
| 2448 | + | |
2448 | 2449 | | |
2449 | 2450 | | |
2450 | 2451 | | |
| |||
0 commit comments