dlm: never return invalid nodeid by dlm_our_nodeid()

Alexander Aring · teigland · commit 90ad918e371f · 2024-08-08T15:15:07.000-05:00
This patch will remote the return of an invalid nodeid value when
local_comm is not set. This case should never happen as the DLM stack
tries to compare valid nodeids with an invalid nodeid returned by
dlm_our_nodeid(). Instead we let it crash to getting at least recognized
if we running into such state.

Signed-off-by: Alexander Aring &lt;aahringo@redhat.com&gt;
Signed-off-by: David Teigland &lt;teigland@redhat.com&gt;
diff --git a/fs/dlm/config.c b/fs/dlm/config.c
@@ -928,7 +928,7 @@ int dlm_comm_seq(int nodeid, uint32_t *seq)
 
 int dlm_our_nodeid(void)
 {
-	return local_comm ? local_comm->nodeid : 0;
+	return local_comm->nodeid;
 }
 
 /* num 0 is first addr, num 1 is second addr */

Original file line number	Diff line number	Diff line change
`@@ -928,7 +928,7 @@ int dlm_comm_seq(int nodeid, uint32_t *seq)`
`928`	`928`
`929`	`929`	`int dlm_our_nodeid(void)`
`930`	`930`	`{`
`931`		`- return local_comm ? local_comm->nodeid : 0;`
	`931`	`+ return local_comm->nodeid;`
`932`	`932`	`}`
`933`	`933`
`934`	`934`	`/* num 0 is first addr, num 1 is second addr */`