Skip to content

Commit 92a9c57

Browse files
rwk-gitLorenzo Pieralisi
authored andcommitted
PCI: rockchip: Remove writes to unused registers
Remove write accesses to registers that are marked "unused" (and therefore read-only) in the technical reference manual (TRM) (see RK3399 TRM 17.6.8.1) Link: https://lore.kernel.org/r/[email protected] Tested-by: Damien Le Moal <[email protected]> Signed-off-by: Rick Wertenbroek <[email protected]> Signed-off-by: Lorenzo Pieralisi <[email protected]> Reviewed-by: Damien Le Moal <[email protected]>
1 parent ac9a786 commit 92a9c57

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

drivers/pci/controller/pcie-rockchip-ep.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,6 @@ static void rockchip_pcie_clear_ep_ob_atu(struct rockchip_pcie *rockchip,
6161
ROCKCHIP_PCIE_AT_OB_REGION_DESC0(region));
6262
rockchip_pcie_write(rockchip, 0,
6363
ROCKCHIP_PCIE_AT_OB_REGION_DESC1(region));
64-
rockchip_pcie_write(rockchip, 0,
65-
ROCKCHIP_PCIE_AT_OB_REGION_CPU_ADDR0(region));
66-
rockchip_pcie_write(rockchip, 0,
67-
ROCKCHIP_PCIE_AT_OB_REGION_CPU_ADDR1(region));
6864
}
6965

7066
static void rockchip_pcie_prog_ep_ob_atu(struct rockchip_pcie *rockchip, u8 fn,
@@ -114,12 +110,6 @@ static void rockchip_pcie_prog_ep_ob_atu(struct rockchip_pcie *rockchip, u8 fn,
114110
PCIE_CORE_OB_REGION_ADDR0_LO_ADDR);
115111
addr1 = upper_32_bits(cpu_addr);
116112
}
117-
118-
/* CPU bus address region */
119-
rockchip_pcie_write(rockchip, addr0,
120-
ROCKCHIP_PCIE_AT_OB_REGION_CPU_ADDR0(r));
121-
rockchip_pcie_write(rockchip, addr1,
122-
ROCKCHIP_PCIE_AT_OB_REGION_CPU_ADDR1(r));
123113
}
124114

125115
static int rockchip_pcie_ep_write_header(struct pci_epc *epc, u8 fn, u8 vfn,

0 commit comments

Comments
 (0)