drm/amdgpu/mes: fix use-after-free issue

Jack Xiao · alexdeucher · commit 948255282074 · 2024-04-23T23:23:46.000-04:00
Delete fence fallback timer to fix the ramdom
use-after-free issue.

v2: move to amdgpu_mes.c

Signed-off-by: Jack Xiao &lt;Jack.Xiao@amd.com&gt;
Acked-by: Lijo Lazar &lt;lijo.lazar@amd.com&gt;
Acked-by: Christian König &lt;christian.koenig@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
@@ -1132,6 +1132,7 @@ void amdgpu_mes_remove_ring(struct amdgpu_device *adev,
 		return;
 
 	amdgpu_mes_remove_hw_queue(adev, ring->hw_queue_id);
+	del_timer_sync(&ring->fence_drv.fallback_timer);
 	amdgpu_ring_fini(ring);
 	kfree(ring);
 }

Original file line number	Diff line number	Diff line change
`@@ -1132,6 +1132,7 @@ void amdgpu_mes_remove_ring(struct amdgpu_device *adev,`
`1132`	`1132`	`return;`
`1133`	`1133`
`1134`	`1134`	`amdgpu_mes_remove_hw_queue(adev, ring->hw_queue_id);`
	`1135`	`+ del_timer_sync(&ring->fence_drv.fallback_timer);`
`1135`	`1136`	`amdgpu_ring_fini(ring);`
`1136`	`1137`	`kfree(ring);`
`1137`	`1138`	`}`