Commit 9f68eab
mm/damon/core: prevent unnecessary overflow in damos_set_effective_quota()
On 32-bit systems, the throughput calculation in
damos_set_effective_quota() is prone to unnecessary multiplication
overflow. Using mult_frac() to fix it.
Andrew Paniakin also recently found and privately reported this issue, on
64 bit systems. This can also happen on 64-bit systems, once the charged
size exceeds ~17 TiB. On systems running for long time in production,
this issue can actually happen.
More specifically, when a DAMOS scheme having the time quota run for
longtime, throughput calculation can overflow and set esz too small. As a
result, speed of the scheme get unexpectedly slow.
Link: https://lkml.kernel.org/r/[email protected]
Fixes: 1cd2430 ("mm/damon/schemes: implement time quota")
Signed-off-by: Quanmin Yan <[email protected]>
Reported-by: Andrew Paniakin <[email protected]>
Reviewed-by: SeongJae Park <[email protected]>
Cc: Kefeng Wang <[email protected]>
Cc: ze zuo <[email protected]>
Cc: <[email protected]> [5.16+]
Signed-off-by: Andrew Morton <[email protected]>1 parent 6310c14 commit 9f68eab
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2073 | 2073 | | |
2074 | 2074 | | |
2075 | 2075 | | |
2076 | | - | |
2077 | | - | |
| 2076 | + | |
| 2077 | + | |
2078 | 2078 | | |
2079 | 2079 | | |
2080 | 2080 | | |
| |||
0 commit comments