Skip to content

Commit a200df7

Browse files
committed
ALSA: seq: Don't clear bank selection at event -> UMP MIDI2 conversion
The current code to convert from a legacy sequencer event to UMP MIDI2 clears the bank selection at each time the program change is submitted. This is confusing and may lead to incorrect bank values tranmitted to the destination in the end. Drop the line to clear the bank info and keep the provided values. Fixes: e9e0281 ("ALSA: seq: Automatic conversion of UMP events") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 8a42886 commit a200df7

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

sound/core/seq/seq_ump_convert.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -892,7 +892,6 @@ static int pgm_ev_to_ump_midi2(const struct snd_seq_event *event,
892892
data->pg.bank_msb = cc->cc_bank_msb;
893893
data->pg.bank_lsb = cc->cc_bank_lsb;
894894
cc->bank_set = 0;
895-
cc->cc_bank_msb = cc->cc_bank_lsb = 0;
896895
}
897896
return 1;
898897
}

0 commit comments

Comments
 (0)