staging: gpib: Correct CamelCase for VALID enums

Michael Rubin · gregkh · commit a8e233d0747f · 2025-03-20T06:57:05.000-07:00
Adhere to Linux kernel coding style. Reported by checkpatch CHECK: Avoid CamelCase Signed-off-by: Michael Rubin <matchstick@neverthere.org> Acked-By: Dave Penkler <dpenkler@gmail.com> Link: https://lore.kernel.org/r/20250319211827.9854-3-matchstick@neverthere.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
@@ -1017,7 +1017,7 @@ static int agilent_82357a_line_status(const gpib_board_t *board)
 	struct usb_device *usb_dev;
 	struct agilent_82357a_register_pairlet bus_status;
 	int retval;
-	int status = ValidALL;
+	int status = VALID_ALL;
 
 	if (!a_priv->bus_interface)
 		return -ENODEV;
diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb7210/cb7210.c
@@ -379,7 +379,7 @@ static int cb7210_accel_write(gpib_board_t *board, uint8_t *buffer, size_t lengt
 
 static int cb7210_line_status(const gpib_board_t *board)
 {
-	int status = ValidALL;
+	int status = VALID_ALL;
 	int bsr_bits;
 	struct cb7210_priv *cb_priv;
 
diff --git a/drivers/staging/gpib/common/iblib.c b/drivers/staging/gpib/common/iblib.c
@@ -76,7 +76,7 @@ static int check_for_command_acceptors(gpib_board_t *board)
 	if (lines < 0)
 		return lines;
 
-	if ((lines & ValidNRFD) && (lines & ValidNDAC))	{
+	if ((lines & VALID_NRFD) && (lines & VALID_NDAC))	{
 		if ((lines & BUS_NRFD) == 0 && (lines & BUS_NDAC) == 0)
 			return -ENOTCONN;
 	}
@@ -520,7 +520,7 @@ int general_ibstatus(gpib_board_t *board, const gpib_status_queue_t *device,
 		status &= ~TIMO;
 		/* get real SRQI status if we can */
 		if (iblines(board, &line_status) == 0) {
-			if ((line_status & ValidSRQ)) {
+			if ((line_status & VALID_SRQ)) {
 				if ((line_status & BUS_SRQ))
 					status |= SRQI;
 				else
diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/gpib/eastwood/fluke_gpib.c
@@ -195,7 +195,7 @@ static void fluke_return_to_local(gpib_board_t *board)
 
 static int fluke_line_status(const gpib_board_t *board)
 {
-	int status = ValidALL;
+	int status = VALID_ALL;
 	int bsr_bits;
 	struct fluke_priv *e_priv;
 
diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
@@ -229,7 +229,7 @@ static void fmh_gpib_return_to_local(gpib_board_t *board)
 
 static int fmh_gpib_line_status(const gpib_board_t *board)
 {
-	int status = ValidALL;
+	int status = VALID_ALL;
 	int bsr_bits;
 	struct fmh_priv *e_priv;
 	struct nec7210_priv *nec_priv;
diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpib/gpio/gpib_bitbang.c
@@ -1031,7 +1031,7 @@ static void bb_return_to_local(gpib_board_t *board)
 
 static int bb_line_status(const gpib_board_t *board)
 {
-	int line_status = ValidALL;
+	int line_status = VALID_ALL;
 
 	if (gpiod_get_value(REN) == 0)
 		line_status |= BUS_REN;
diff --git a/drivers/staging/gpib/ines/ines_gpib.c b/drivers/staging/gpib/ines/ines_gpib.c
@@ -27,7 +27,7 @@ MODULE_DESCRIPTION("GPIB driver for Ines iGPIB 72010");
 
 int ines_line_status(const gpib_board_t *board)
 {
-	int status = ValidALL;
+	int status = VALID_ALL;
 	int bcm_bits;
 	struct ines_priv *ines_priv;
 
diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -658,7 +658,7 @@ static void usb_gpib_interface_clear(gpib_board_t *board, int assert)
 static int usb_gpib_line_status(const gpib_board_t *board)
 {
 	int buffer;
-	int line_status = ValidALL;   /* all lines will be read */
+	int line_status = VALID_ALL;   /* all lines will be read */
 	struct list_head *p, *q;
 	WQT *item;
 	unsigned long flags;
diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
@@ -1508,7 +1508,7 @@ static int ni_usb_line_status(const gpib_board_t *board)
 	int bytes_written = 0, bytes_read = 0;
 	int i = 0;
 	unsigned int bsr_bits;
-	int line_status = ValidALL;
+	int line_status = VALID_ALL;
 	// NI windows driver reads 0xd(HSSEL), 0xc (ARD0), 0x1f (BSR)
 
 	if (!ni_priv->bus_interface)
diff --git a/drivers/staging/gpib/tms9914/tms9914.c b/drivers/staging/gpib/tms9914/tms9914.c
@@ -391,7 +391,7 @@ static unsigned int update_status_nolock(gpib_board_t *board, struct tms9914_pri
 int tms9914_line_status(const gpib_board_t *board, struct tms9914_priv *priv)
 {
 	int bsr_bits;
-	int status = ValidALL;
+	int status = VALID_ALL;
 
 	bsr_bits = read_byte(priv, BSR);
 
diff --git a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
@@ -150,7 +150,7 @@ MODULE_DESCRIPTION("GPIB driver for National Instruments boards using tnt4882 or
 
 static int tnt4882_line_status(const gpib_board_t *board)
 {
-	int status = ValidALL;
+	int status = VALID_ALL;
 	int bcsr_bits;
 	struct tnt4882_priv *tnt_priv;
 
diff --git a/drivers/staging/gpib/uapi/gpib_user.h b/drivers/staging/gpib/uapi/gpib_user.h
@@ -106,15 +106,15 @@ enum eos_flags {
 
 /* GPIB Bus Control Lines bit vector */
 enum bus_control_line {
-	ValidDAV = 0x01,
-	ValidNDAC = 0x02,
-	ValidNRFD = 0x04,
-	ValidIFC = 0x08,
-	ValidREN = 0x10,
-	ValidSRQ = 0x20,
-	ValidATN = 0x40,
-	ValidEOI = 0x80,
-	ValidALL = 0xff,
+	VALID_DAV = 0x01,
+	VALID_NDAC = 0x02,
+	VALID_NRFD = 0x04,
+	VALID_IFC = 0x08,
+	VALID_REN = 0x10,
+	VALID_SRQ = 0x20,
+	VALID_ATN = 0x40,
+	VALID_EOI = 0x80,
+	VALID_ALL = 0xff,
 	BUS_DAV = 0x0100,		/* DAV	line status bit */
 	BUS_NDAC = 0x0200,		/* NDAC line status bit */
 	BUS_NRFD = 0x0400,		/* NRFD line status bit */

Original file line number	Diff line number	Diff line change
`@@ -379,7 +379,7 @@ static int cb7210_accel_write(gpib_board_t board, uint8_t buffer, size_t lengt`
`379`	`379`
`380`	`380`	`static int cb7210_line_status(const gpib_board_t *board)`
`381`	`381`	`{`
`382`		`- int status = ValidALL;`
	`382`	`+ int status = VALID_ALL;`
`383`	`383`	`int bsr_bits;`
`384`	`384`	`struct cb7210_priv *cb_priv;`
`385`	`385`
Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ static void fluke_return_to_local(gpib_board_t *board)`
`195`	`195`
`196`	`196`	`static int fluke_line_status(const gpib_board_t *board)`
`197`	`197`	`{`
`198`		`- int status = ValidALL;`
	`198`	`+ int status = VALID_ALL;`
`199`	`199`	`int bsr_bits;`
`200`	`200`	`struct fluke_priv *e_priv;`
`201`	`201`
Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ static void fmh_gpib_return_to_local(gpib_board_t *board)`
`229`	`229`
`230`	`230`	`static int fmh_gpib_line_status(const gpib_board_t *board)`
`231`	`231`	`{`
`232`		`- int status = ValidALL;`
	`232`	`+ int status = VALID_ALL;`
`233`	`233`	`int bsr_bits;`
`234`	`234`	`struct fmh_priv *e_priv;`
`235`	`235`	`struct nec7210_priv *nec_priv;`
Original file line number	Diff line number	Diff line change
`@@ -1031,7 +1031,7 @@ static void bb_return_to_local(gpib_board_t *board)`
`1031`	`1031`
`1032`	`1032`	`static int bb_line_status(const gpib_board_t *board)`
`1033`	`1033`	`{`
`1034`		`- int line_status = ValidALL;`
	`1034`	`+ int line_status = VALID_ALL;`
`1035`	`1035`
`1036`	`1036`	`if (gpiod_get_value(REN) == 0)`
`1037`	`1037`	`line_status \|= BUS_REN;`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ MODULE_DESCRIPTION("GPIB driver for Ines iGPIB 72010");`
`27`	`27`
`28`	`28`	`int ines_line_status(const gpib_board_t *board)`
`29`	`29`	`{`
`30`		`- int status = ValidALL;`
	`30`	`+ int status = VALID_ALL;`
`31`	`31`	`int bcm_bits;`
`32`	`32`	`struct ines_priv *ines_priv;`
`33`	`33`
Original file line number	Diff line number	Diff line change
`@@ -658,7 +658,7 @@ static void usb_gpib_interface_clear(gpib_board_t *board, int assert)`
`658`	`658`	`static int usb_gpib_line_status(const gpib_board_t *board)`
`659`	`659`	`{`
`660`	`660`	`int buffer;`
`661`		`- int line_status = ValidALL; /* all lines will be read */`
	`661`	`+ int line_status = VALID_ALL; /* all lines will be read */`
`662`	`662`	`struct list_head p, q;`
`663`	`663`	`WQT *item;`
`664`	`664`	`unsigned long flags;`
Original file line number	Diff line number	Diff line change
`@@ -391,7 +391,7 @@ static unsigned int update_status_nolock(gpib_board_t *board, struct tms9914_pri`
`391`	`391`	`int tms9914_line_status(const gpib_board_t board, struct tms9914_priv priv)`
`392`	`392`	`{`
`393`	`393`	`int bsr_bits;`
`394`		`- int status = ValidALL;`
	`394`	`+ int status = VALID_ALL;`
`395`	`395`
`396`	`396`	`bsr_bits = read_byte(priv, BSR);`
`397`	`397`