Fix a potential abuse of seq_printf() format string in drivers

zq-david-wang · gregkh · commit acfeb6defcb9 · 2024-11-22T15:31:35.000+01:00
Using device name as format string of seq_printf() is proned to "Format string attack", opens possibility for exploitation. Seq_puts() is safer and more efficient. Signed-off-by: David Wang <00107082@163.com> Reviewed-by: Kees Cook <kees@kernel.org> Link: https://lore.kernel.org/r/20241120053055.225195-1-00107082@163.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/gpio/gpio-aspeed-sgpio.c b/drivers/gpio/gpio-aspeed-sgpio.c
@@ -420,7 +420,7 @@ static void aspeed_sgpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
 	int offset;
 
 	irqd_to_aspeed_sgpio_data(d, &gpio, &bank, &bit, &offset);
-	seq_printf(p, dev_name(gpio->dev));
+	seq_puts(p, dev_name(gpio->dev));
 }
 
 static const struct irq_chip aspeed_sgpio_irq_chip = {
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
@@ -1102,7 +1102,7 @@ static void aspeed_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
 	if (rc)
 		return;
 
-	seq_printf(p, dev_name(gpio->dev));
+	seq_puts(p, dev_name(gpio->dev));
 }
 
 static const struct irq_chip aspeed_gpio_irq_chip = {
diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
@@ -249,7 +249,7 @@ static void ep93xx_irq_print_chip(struct irq_data *data, struct seq_file *p)
 {
 	struct gpio_chip *gc = irq_data_get_irq_chip_data(data);
 
-	seq_printf(p, dev_name(gc->parent));
+	seq_puts(p, dev_name(gc->parent));
 }
 
 static const struct irq_chip gpio_eic_irq_chip = {
diff --git a/drivers/gpio/gpio-hlwd.c b/drivers/gpio/gpio-hlwd.c
@@ -210,7 +210,7 @@ static void hlwd_gpio_irq_print_chip(struct irq_data *data, struct seq_file *p)
 	struct hlwd_gpio *hlwd =
 		gpiochip_get_data(irq_data_get_irq_chip_data(data));
 
-	seq_printf(p, dev_name(hlwd->dev));
+	seq_puts(p, dev_name(hlwd->dev));
 }
 
 static const struct irq_chip hlwd_gpio_irq_chip = {
diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c
@@ -331,7 +331,7 @@ static void mlxbf2_gpio_irq_print_chip(struct irq_data *irqd,
 	struct gpio_chip *gc = irq_data_get_irq_chip_data(irqd);
 	struct mlxbf2_gpio_context *gs = gpiochip_get_data(gc);
 
-	seq_printf(p, dev_name(gs->dev));
+	seq_puts(p, dev_name(gs->dev));
 }
 
 static const struct irq_chip mlxbf2_gpio_irq_chip = {
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
@@ -715,7 +715,7 @@ static void omap_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
 {
 	struct gpio_bank *bank = omap_irq_data_get_bank(d);
 
-	seq_printf(p, dev_name(bank->dev));
+	seq_puts(p, dev_name(bank->dev));
 }
 
 static const struct irq_chip omap_gpio_irq_chip = {
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
@@ -815,7 +815,7 @@ static void pca953x_irq_print_chip(struct irq_data *data, struct seq_file *p)
 {
 	struct gpio_chip *gc = irq_data_get_irq_chip_data(data);
 
-	seq_printf(p, dev_name(gc->parent));
+	seq_puts(p, dev_name(gc->parent));
 }
 
 static const struct irq_chip pca953x_irq_chip = {
diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
@@ -291,7 +291,7 @@ static void pl061_irq_print_chip(struct irq_data *data, struct seq_file *p)
 {
 	struct gpio_chip *gc = irq_data_get_irq_chip_data(data);
 
-	seq_printf(p, dev_name(gc->parent));
+	seq_puts(p, dev_name(gc->parent));
 }
 
 static const struct irq_chip pl061_irq_chip = {
diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
@@ -600,7 +600,7 @@ static void tegra_gpio_irq_print_chip(struct irq_data *d, struct seq_file *s)
 {
 	struct gpio_chip *chip = irq_data_get_irq_chip_data(d);
 
-	seq_printf(s, dev_name(chip->parent));
+	seq_puts(s, dev_name(chip->parent));
 }
 
 static const struct irq_chip tegra_gpio_irq_chip = {
diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
@@ -610,7 +610,7 @@ static void tegra186_irq_print_chip(struct irq_data *data, struct seq_file *p)
 {
 	struct gpio_chip *gc = irq_data_get_irq_chip_data(data);
 
-	seq_printf(p, dev_name(gc->parent));
+	seq_puts(p, dev_name(gc->parent));
 }
 
 static const struct irq_chip tegra186_gpio_irq_chip = {
diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c
@@ -275,7 +275,7 @@ static void tqmx86_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
 {
 	struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
 
-	seq_printf(p, gc->label);
+	seq_puts(p, gc->label);
 }
 
 static const struct irq_chip tqmx86_gpio_irq_chip = {
diff --git a/drivers/gpio/gpio-visconti.c b/drivers/gpio/gpio-visconti.c
@@ -142,7 +142,7 @@ static void visconti_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
 	struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
 	struct visconti_gpio *priv = gpiochip_get_data(gc);
 
-	seq_printf(p, dev_name(priv->dev));
+	seq_puts(p, dev_name(priv->dev));
 }
 
 static const struct irq_chip visconti_gpio_irq_chip = {
diff --git a/drivers/gpio/gpio-xgs-iproc.c b/drivers/gpio/gpio-xgs-iproc.c
@@ -198,7 +198,7 @@ static void iproc_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
 	struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
 	struct iproc_gpio_chip *chip = to_iproc_gpio(gc);
 
-	seq_printf(p, dev_name(chip->dev));
+	seq_puts(p, dev_name(chip->dev));
 }
 
 static const struct irq_chip iproc_gpio_irq_chip = {
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
@@ -400,7 +400,7 @@ static void gic_irq_print_chip(struct irq_data *d, struct seq_file *p)
 	struct gic_chip_data *gic = irq_data_get_irq_chip_data(d);
 
 	if (gic->domain->pm_dev)
-		seq_printf(p, gic->domain->pm_dev->of_node->name);
+		seq_puts(p, gic->domain->pm_dev->of_node->name);
 	else
 		seq_printf(p, "GIC-%d", (int)(gic - &gic_data[0]));
 }
diff --git a/drivers/irqchip/irq-mvebu-pic.c b/drivers/irqchip/irq-mvebu-pic.c
@@ -71,7 +71,7 @@ static void mvebu_pic_print_chip(struct irq_data *d, struct seq_file *p)
 {
 	struct mvebu_pic *pic = irq_data_get_irq_chip_data(d);
 
-	seq_printf(p, dev_name(&pic->pdev->dev));
+	seq_puts(p, dev_name(&pic->pdev->dev));
 }
 
 static const struct irq_chip mvebu_pic_chip = {
diff --git a/drivers/irqchip/irq-versatile-fpga.c b/drivers/irqchip/irq-versatile-fpga.c
@@ -69,7 +69,7 @@ static void fpga_irq_print_chip(struct irq_data *d, struct seq_file *p)
 {
 	struct fpga_irq_data *f = irq_data_get_irq_chip_data(d);
 
-	seq_printf(p, irq_domain_get_of_node(f->domain)->name);
+	seq_puts(p, irq_domain_get_of_node(f->domain)->name);
 }
 
 static const struct irq_chip fpga_chip = {
diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -309,7 +309,7 @@ static void iproc_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
 	struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
 	struct iproc_gpio *chip = gpiochip_get_data(gc);
 
-	seq_printf(p, dev_name(chip->dev));
+	seq_puts(p, dev_name(chip->dev));
 }
 
 static const struct irq_chip iproc_gpio_irq_chip = {
diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -734,7 +734,7 @@ static void armada_37xx_irq_print_chip(struct irq_data *d, struct seq_file *p)
 	struct gpio_chip *chip = irq_data_get_irq_chip_data(d);
 	struct armada_37xx_pinctrl *info = gpiochip_get_data(chip);
 
-	seq_printf(p, info->data->name);
+	seq_puts(p, info->data->name);
 }
 
 static const struct irq_chip armada_37xx_irqchip = {
diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
@@ -569,7 +569,7 @@ static void mcp23s08_irq_print_chip(struct irq_data *d, struct seq_file *p)
 	struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
 	struct mcp23s08 *mcp = gpiochip_get_data(gc);
 
-	seq_printf(p, dev_name(mcp->dev));
+	seq_puts(p, dev_name(mcp->dev));
 }
 
 static const struct irq_chip mcp23s08_irq_chip = {
diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
@@ -599,7 +599,7 @@ static void stmfx_pinctrl_irq_print_chip(struct irq_data *d, struct seq_file *p)
 	struct gpio_chip *gpio_chip = irq_data_get_irq_chip_data(d);
 	struct stmfx_pinctrl *pctl = gpiochip_get_data(gpio_chip);
 
-	seq_printf(p, dev_name(pctl->dev));
+	seq_puts(p, dev_name(pctl->dev));
 }
 
 static const struct irq_chip stmfx_pinctrl_irq_chip = {
diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c
@@ -584,7 +584,7 @@ static void sx150x_irq_print_chip(struct irq_data *d, struct seq_file *p)
 	struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
 	struct sx150x_pinctrl *pctl = gpiochip_get_data(gc);
 
-	seq_printf(p, pctl->client->name);
+	seq_puts(p, pctl->client->name);
 }
 
 static const struct irq_chip sx150x_irq_chip = {
diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -2290,7 +2290,7 @@ static void rzg2l_gpio_irq_print_chip(struct irq_data *data, struct seq_file *p)
 {
 	struct gpio_chip *gc = irq_data_get_irq_chip_data(data);
 
-	seq_printf(p, dev_name(gc->parent));
+	seq_puts(p, dev_name(gc->parent));
 }
 
 static int rzg2l_gpio_irq_set_wake(struct irq_data *data, unsigned int on)

Original file line number	Diff line number	Diff line change
`@@ -420,7 +420,7 @@ static void aspeed_sgpio_irq_print_chip(struct irq_data d, struct seq_file p)`
`420`	`420`	`int offset;`
`421`	`421`
`422`	`422`	`irqd_to_aspeed_sgpio_data(d, &gpio, &bank, &bit, &offset);`
`423`		`- seq_printf(p, dev_name(gpio->dev));`
	`423`	`+ seq_puts(p, dev_name(gpio->dev));`
`424`	`424`	`}`
`425`	`425`
`426`	`426`	`static const struct irq_chip aspeed_sgpio_irq_chip = {`
Original file line number	Diff line number	Diff line change
`@@ -1102,7 +1102,7 @@ static void aspeed_gpio_irq_print_chip(struct irq_data d, struct seq_file p)`
`1102`	`1102`	`if (rc)`
`1103`	`1103`	`return;`
`1104`	`1104`
`1105`		`- seq_printf(p, dev_name(gpio->dev));`
	`1105`	`+ seq_puts(p, dev_name(gpio->dev));`
`1106`	`1106`	`}`
`1107`	`1107`
`1108`	`1108`	`static const struct irq_chip aspeed_gpio_irq_chip = {`
Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ static void ep93xx_irq_print_chip(struct irq_data data, struct seq_file p)`
`249`	`249`	`{`
`250`	`250`	`struct gpio_chip *gc = irq_data_get_irq_chip_data(data);`
`251`	`251`
`252`		`- seq_printf(p, dev_name(gc->parent));`
	`252`	`+ seq_puts(p, dev_name(gc->parent));`
`253`	`253`	`}`
`254`	`254`
`255`	`255`	`static const struct irq_chip gpio_eic_irq_chip = {`
Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ static void hlwd_gpio_irq_print_chip(struct irq_data data, struct seq_file p)`
`210`	`210`	`struct hlwd_gpio *hlwd =`
`211`	`211`	`gpiochip_get_data(irq_data_get_irq_chip_data(data));`
`212`	`212`
`213`		`- seq_printf(p, dev_name(hlwd->dev));`
	`213`	`+ seq_puts(p, dev_name(hlwd->dev));`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`static const struct irq_chip hlwd_gpio_irq_chip = {`
Original file line number	Diff line number	Diff line change
`@@ -331,7 +331,7 @@ static void mlxbf2_gpio_irq_print_chip(struct irq_data *irqd,`
`331`	`331`	`struct gpio_chip *gc = irq_data_get_irq_chip_data(irqd);`
`332`	`332`	`struct mlxbf2_gpio_context *gs = gpiochip_get_data(gc);`
`333`	`333`
`334`		`- seq_printf(p, dev_name(gs->dev));`
	`334`	`+ seq_puts(p, dev_name(gs->dev));`
`335`	`335`	`}`
`336`	`336`
`337`	`337`	`static const struct irq_chip mlxbf2_gpio_irq_chip = {`
Original file line number	Diff line number	Diff line change
`@@ -715,7 +715,7 @@ static void omap_gpio_irq_print_chip(struct irq_data d, struct seq_file p)`
`715`	`715`	`{`
`716`	`716`	`struct gpio_bank *bank = omap_irq_data_get_bank(d);`
`717`	`717`
`718`		`- seq_printf(p, dev_name(bank->dev));`
	`718`	`+ seq_puts(p, dev_name(bank->dev));`
`719`	`719`	`}`
`720`	`720`
`721`	`721`	`static const struct irq_chip omap_gpio_irq_chip = {`
Original file line number	Diff line number	Diff line change
`@@ -815,7 +815,7 @@ static void pca953x_irq_print_chip(struct irq_data data, struct seq_file p)`
`815`	`815`	`{`
`816`	`816`	`struct gpio_chip *gc = irq_data_get_irq_chip_data(data);`
`817`	`817`
`818`		`- seq_printf(p, dev_name(gc->parent));`
	`818`	`+ seq_puts(p, dev_name(gc->parent));`
`819`	`819`	`}`
`820`	`820`
`821`	`821`	`static const struct irq_chip pca953x_irq_chip = {`
Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ static void pl061_irq_print_chip(struct irq_data data, struct seq_file p)`
`291`	`291`	`{`
`292`	`292`	`struct gpio_chip *gc = irq_data_get_irq_chip_data(data);`
`293`	`293`
`294`		`- seq_printf(p, dev_name(gc->parent));`
	`294`	`+ seq_puts(p, dev_name(gc->parent));`
`295`	`295`	`}`
`296`	`296`
`297`	`297`	`static const struct irq_chip pl061_irq_chip = {`
Original file line number	Diff line number	Diff line change
`@@ -600,7 +600,7 @@ static void tegra_gpio_irq_print_chip(struct irq_data d, struct seq_file s)`
`600`	`600`	`{`
`601`	`601`	`struct gpio_chip *chip = irq_data_get_irq_chip_data(d);`
`602`	`602`
`603`		`- seq_printf(s, dev_name(chip->parent));`
	`603`	`+ seq_puts(s, dev_name(chip->parent));`
`604`	`604`	`}`
`605`	`605`
`606`	`606`	`static const struct irq_chip tegra_gpio_irq_chip = {`
Original file line number	Diff line number	Diff line change
`@@ -610,7 +610,7 @@ static void tegra186_irq_print_chip(struct irq_data data, struct seq_file p)`
`610`	`610`	`{`
`611`	`611`	`struct gpio_chip *gc = irq_data_get_irq_chip_data(data);`
`612`	`612`
`613`		`- seq_printf(p, dev_name(gc->parent));`
	`613`	`+ seq_puts(p, dev_name(gc->parent));`
`614`	`614`	`}`
`615`	`615`
`616`	`616`	`static const struct irq_chip tegra186_gpio_irq_chip = {`