HID: picoLCD: Constify lcd_ops

krzk · lag-linaro · commit b8beae949433 · 2024-05-03T10:45:34.000+01:00
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org> Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-15-1aaa82b07bc6@kernel.org Signed-off-by: Lee Jones <lee@kernel.org>
diff --git a/drivers/hid/hid-picolcd_lcd.c b/drivers/hid/hid-picolcd_lcd.c
@@ -46,7 +46,7 @@ static int picolcd_check_lcd_fb(struct lcd_device *ldev, struct fb_info *fb)
 	return fb && fb == picolcd_fbinfo((struct picolcd_data *)lcd_get_data(ldev));
 }
 
-static struct lcd_ops picolcd_lcdops = {
+static const struct lcd_ops picolcd_lcdops = {
 	.get_contrast   = picolcd_get_contrast,
 	.set_contrast   = picolcd_set_contrast,
 	.check_fb       = picolcd_check_lcd_fb,

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ static int picolcd_check_lcd_fb(struct lcd_device ldev, struct fb_info fb)`
`46`	`46`	`return fb && fb == picolcd_fbinfo((struct picolcd_data *)lcd_get_data(ldev));`
`47`	`47`	`}`
`48`	`48`
`49`		`-static struct lcd_ops picolcd_lcdops = {`
	`49`	`+static const struct lcd_ops picolcd_lcdops = {`
`50`	`50`	`.get_contrast = picolcd_get_contrast,`
`51`	`51`	`.set_contrast = picolcd_set_contrast,`
`52`	`52`	`.check_fb = picolcd_check_lcd_fb,`