drivers: remoteproc: xlnx: Fix uninitialized tcm mode

tnmysh · mathieupoirier · commit b9511056ce5b · 2024-04-24T15:19:38.000-06:00
Add "else" case for default tcm mode to silent following static check: zynqmp_r5_cluster_init() error: uninitialized symbol 'tcm_mode'. Fixes: a6b974b ("drivers: remoteproc: xlnx: Add Versal and Versal-NET support") Signed-off-by: Tanmay Shah <tanmay.shah@amd.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/20240424163344.1344304-1-tanmay.shah@amd.com Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/xlnx_r5_remoteproc.c
@@ -1006,6 +1006,8 @@ static int zynqmp_r5_cluster_init(struct zynqmp_r5_cluster *cluster)
 			tcm_mode = PM_RPU_TCM_COMB;
 		else
 			tcm_mode = PM_RPU_TCM_SPLIT;
+	} else {
+		tcm_mode = PM_RPU_TCM_COMB;
 	}
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -1006,6 +1006,8 @@ static int zynqmp_r5_cluster_init(struct zynqmp_r5_cluster *cluster)`
`1006`	`1006`	`tcm_mode = PM_RPU_TCM_COMB;`
`1007`	`1007`	`else`
`1008`	`1008`	`tcm_mode = PM_RPU_TCM_SPLIT;`
	`1009`	`+ } else {`
	`1010`	`+ tcm_mode = PM_RPU_TCM_COMB;`
`1009`	`1011`	`}`
`1010`	`1012`
`1011`	`1013`	`/*`