Skip to content

Commit bc642d7

Browse files
namjaejeonsmfrench
authored andcommitted
ksmbd: fix uninitialized symbol 'share' in smb2_tree_connect()
Fix uninitialized symbol 'share' in smb2_tree_connect(). Fixes: e9d8c2f ("ksmbd: add continuous availability share parameter") Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Namjae Jeon <[email protected]> Signed-off-by: Steve French <[email protected]>
1 parent e67572c commit bc642d7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

fs/smb/server/smb2pdu.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1926,7 +1926,7 @@ int smb2_tree_connect(struct ksmbd_work *work)
19261926
struct ksmbd_session *sess = work->sess;
19271927
char *treename = NULL, *name = NULL;
19281928
struct ksmbd_tree_conn_status status;
1929-
struct ksmbd_share_config *share;
1929+
struct ksmbd_share_config *share = NULL;
19301930
int rc = -EINVAL;
19311931

19321932
WORK_BUFFERS(work, req, rsp);
@@ -1988,7 +1988,7 @@ int smb2_tree_connect(struct ksmbd_work *work)
19881988
write_unlock(&sess->tree_conns_lock);
19891989
rsp->StructureSize = cpu_to_le16(16);
19901990
out_err1:
1991-
if (server_conf.flags & KSMBD_GLOBAL_FLAG_DURABLE_HANDLE &&
1991+
if (server_conf.flags & KSMBD_GLOBAL_FLAG_DURABLE_HANDLE && share &&
19921992
test_share_config_flag(share,
19931993
KSMBD_SHARE_FLAG_CONTINUOUS_AVAILABILITY))
19941994
rsp->Capabilities = SMB2_SHARE_CAP_CONTINUOUS_AVAILABILITY;

0 commit comments

Comments
 (0)