scsi: qla2xxx: Fix for possible memory corruption

Shreyas Deodhar · martinkpetersen · commit c03d740152f7 · 2024-07-10T22:44:09.000-04:00
Init Control Block is dereferenced incorrectly. Correctly dereference ICB Cc: stable@vger.kernel.org Signed-off-by: Shreyas Deodhar <sdeodhar@marvell.com> Signed-off-by: Nilesh Javali <njavali@marvell.com> Link: https://lore.kernel.org/r/20240710171057.35066-4-njavali@marvell.com Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
@@ -4689,7 +4689,7 @@ static void
 qla2x00_number_of_exch(scsi_qla_host_t *vha, u32 *ret_cnt, u16 max_cnt)
 {
 	u32 temp;
-	struct init_cb_81xx *icb = (struct init_cb_81xx *)&vha->hw->init_cb;
+	struct init_cb_81xx *icb = (struct init_cb_81xx *)vha->hw->init_cb;
 	*ret_cnt = FW_DEF_EXCHANGES_CNT;
 
 	if (max_cnt > vha->hw->max_exchg)

Original file line number	Diff line number	Diff line change
`@@ -4689,7 +4689,7 @@ static void`
`4689`	`4689`	`qla2x00_number_of_exch(scsi_qla_host_t vha, u32 ret_cnt, u16 max_cnt)`
`4690`	`4690`	`{`
`4691`	`4691`	`u32 temp;`
`4692`		`- struct init_cb_81xx icb = (struct init_cb_81xx )&vha->hw->init_cb;`
	`4692`	`+ struct init_cb_81xx icb = (struct init_cb_81xx )vha->hw->init_cb;`
`4693`	`4693`	`*ret_cnt = FW_DEF_EXCHANGES_CNT;`
`4694`	`4694`
`4695`	`4695`	`if (max_cnt > vha->hw->max_exchg)`